Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26905

On launching an AICC activity a PHP Notice is triggered, "Undefined variable: currentorg"

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.3
    • Component/s: SCORM
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      It happens every time, due to a missing initialization in the AICC API implementation.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            matteo Matteo Scaramuccia added a comment -

            Patch proposal: https://github.com/scara/moodle/commit/c6e46d37bce3ed098bbc4dab0f84987482f9a639
            Merge from SCORM API implementation

            Show
            matteo Matteo Scaramuccia added a comment - Patch proposal: https://github.com/scara/moodle/commit/c6e46d37bce3ed098bbc4dab0f84987482f9a639 Merge from SCORM API implementation
            Hide
            danmarsden Dan Marsden added a comment -

            pull request filed - thanks Matteo!

            Show
            danmarsden Dan Marsden added a comment - pull request filed - thanks Matteo!
            Hide
            tsala Helen Foster added a comment -

            Matteo, thanks for your report and patch. The fix is included in the latest 2.0.2+.

            Show
            tsala Helen Foster added a comment - Matteo, thanks for your report and patch. The fix is included in the latest 2.0.2+.
            Hide
            matteo Matteo Scaramuccia added a comment -

            Thanks Helen!

            Just for the record (looking at the comments on PULL-499), find below some refs.
            1. My PHP error log at the time of filing the bug:

            [20-Mar-2011 18:41:00] PHP Notice:  Undefined variable: currentorg in C:\Projects\Moodle\www\git\moodle-20\mod\scorm\datamodels\callback.js.php on line 61
             
            [20-Mar-2011 18:41:00] PHP Stack trace:
             
            [20-Mar-2011 18:41:00] PHP   1. {main}() C:\Projects\Moodle\www\git\moodle-20\mod\scorm\api.php:0
             
            [20-Mar-2011 18:41:00] PHP   2. include_once() C:\Projects\Moodle\www\git\moodle-20\mod\scorm\api.php:82
             
            [20-Mar-2011 18:41:00] PHP   3. include_once() C:\Projects\Moodle\www\git\moodle-20\mod\scorm\datamodels\aicc.js.php:207

            2. My PHP conf, from php.ini:

            error_reporting  =  E_ALL | E_STRICT
            ...
            display_errors = On
            ...
            display_startup_errors = On
            ...
            log_errors = On
            ...
            error_log = "C:/PHP/logs/5.2.x/error.log"
            ...
            xdebug.remote_enable=1
            ...
            xdebug.remote_handler="dbgp"
            xdebug.remote_mode=req
            xdebug.profiler_enable=0
            ...

            Show
            matteo Matteo Scaramuccia added a comment - Thanks Helen! Just for the record (looking at the comments on PULL-499), find below some refs. 1. My PHP error log at the time of filing the bug: [20-Mar-2011 18:41:00] PHP Notice: Undefined variable: currentorg in C:\Projects\Moodle\www\git\moodle-20\mod\scorm\datamodels\callback.js.php on line 61   [20-Mar-2011 18:41:00] PHP Stack trace:   [20-Mar-2011 18:41:00] PHP 1. {main}() C:\Projects\Moodle\www\git\moodle-20\mod\scorm\api.php:0   [20-Mar-2011 18:41:00] PHP 2. include_once() C:\Projects\Moodle\www\git\moodle-20\mod\scorm\api.php:82   [20-Mar-2011 18:41:00] PHP 3. include_once() C:\Projects\Moodle\www\git\moodle-20\mod\scorm\datamodels\aicc.js.php:207 2. My PHP conf, from php.ini : error_reporting = E_ALL | E_STRICT ... display_errors = On ... display_startup_errors = On ... log_errors = On ... error_log = "C:/PHP/logs/5.2.x/error.log" ... xdebug.remote_enable=1 ... xdebug.remote_handler="dbgp" xdebug.remote_mode=req xdebug.profiler_enable=0 ...

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/May/11