Loading...

XML

Word

Printable

Affected Branches:
MOODLE_20_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Main Branch:
~~MDL-26940~~-master
Pull Main Diff URL:
https://github.com/FMCorz/moodle/compare/MDL-26940-master
Testing Instructions:
Hide

Test pre-requisites

To be tested on IE8, IE9, Firefox, Chrome

Debug level has to be set to developer

Test steps

Save the file test_popup.php in the root of your Moodle, and access it in your browser

Make sure the invalid buttons throw an error but still open the popup

Make sure the valid ones open a popup

Disable the debug

Make sure all buttons open a popup without throwing an error
Show
Test pre-requisites To be tested on IE8, IE9, Firefox, Chrome Debug level has to be set to developer Test steps Save the file test_popup.php in the root of your Moodle, and access it in your browser Make sure the invalid buttons throw an error but still open the popup Make sure the valid ones open a popup Disable the debug Make sure all buttons open a popup without throwing an error

File: /moodle/lib/javascript-static.js
Line: ~1036
Code: windowobj = window.open(fullurl,args.name,args.options);

Error Message: Invalid argument

It prevents pop up window to open in IE8, IE7. It looks like there is some problem with args.name and args.options as window.open(fullurl) works.

caused a regression

MDL-35754 Quiz in Javascript Popup not working

Participants:: Adrian Greeve, Dan Poltawski, Frédéric Massart, Jai Gupta, Michael de Raadt, Paul Holden