Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26953

theme nonzero: right column disappears in .side-post-only course

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.0.1, 2.0.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Before selecting Nonzero in Theme Selector make sure ALL blocks are on the right-hand side (side-post).
      2. Select Nonzero theme in normal way taking particular note of the SCREENSHOT of what the theme should look like when side-pre is visible.
      3. Once selected CHECK page layout, especially "Side Post ONLY". Is it consistent throughout, including when side blocks are docked?
      4. Now enable EDITING and attempt to MOVE a block or two. You should be able to move a block from SIDE-POST (right) to SIDE-PRE (left).
      5. With blocks in position (left and right) disable editing, and test for consistency, when docking Side-Pre (left) and then Side-Post (right). Normally when all blocks from Side-Pre have been docked the page reverts to a side-post-only layout. This is true also when Side-Pre is still in place and Side-Post is docked.
      6. FURTHER TESTING IF TIME PERMITS: Start by going to Nonzero Custom Settings page (Site Administration > Appearance > Themes -> CLICK the link Nonzero to bring you to the custom settings page for this theme. Here you can change the width settings for both side-pre and side-post. Choose different settings. Save changes and test as per 1 to 5 above.

      Show
      1. Before selecting Nonzero in Theme Selector make sure ALL blocks are on the right-hand side (side-post). 2. Select Nonzero theme in normal way taking particular note of the SCREENSHOT of what the theme should look like when side-pre is visible. 3. Once selected CHECK page layout, especially "Side Post ONLY". Is it consistent throughout, including when side blocks are docked? 4. Now enable EDITING and attempt to MOVE a block or two. You should be able to move a block from SIDE-POST (right) to SIDE-PRE (left). 5. With blocks in position (left and right) disable editing, and test for consistency, when docking Side-Pre (left) and then Side-Post (right). Normally when all blocks from Side-Pre have been docked the page reverts to a side-post-only layout. This is true also when Side-Pre is still in place and Side-Post is docked. 6. FURTHER TESTING IF TIME PERMITS: Start by going to Nonzero Custom Settings page (Site Administration > Appearance > Themes -> CLICK the link Nonzero to bring you to the custom settings page for this theme. Here you can change the width settings for both side-pre and side-post. Choose different settings. Save changes and test as per 1 to 5 above.
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      If you have a .side-post-only course the right column disappears.

      A possible solution seems to be:

      /** Only side post **/
      .side-post-only #page-content #region-main-box {
      margin-left: 0px;
      }

      .side-post-only #page-content #region-post-box {
      margin-left: -[[setting:regionpostwidth]];
      }

      .side-post-only #page-content #region-main {
      margin-left: [[setting:regionpostwidth]];
      }

      .side-post-only #page-content #region-post {
      /*** removed *** left: [[setting:regionsumwidth]]; ***/
      left: [[setting:regionpostwidth]];
      width: [[setting:regionpostwidth]];
      }

      /*** new ***/.pagelayout-frontpage.side-post-only #page-content #region-main-box #region-post-box #region-post,
      .pagelayout-frontpage.has_dock.side-post-only #page-content #region-main-box #region-post-box #region-post,
      .editing.has_dock.side-post-only #page-content #region-main-box #region-post-box #region-post {
      left: [[setting:regionsumwidth]];
      width: [[setting:regionpostwidth]];
      }

      .has_dock.side-post-only .page-middle #region-main-box #region-post-box #region-main-wrap #region-main {
      margin-left: [[setting:regionprewidth]];
      }

      @Mary: I'm a little bit confused about the rendering problems. I hope we can find a fast solution!
      I have the feeling that some body classes (.has_dock, .editing, .side-post-only, .drag) are not working together in the right way!? Dietmar

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29781 Overlay theme FIX for side-post-only layout

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11