Moodle
  1. Moodle
  2. MDL-26957

Forum - My Moodle info a bit messy

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.3
    • Component/s: Forum, My home
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16963

      Description

      In My Moodle the following info prints for each forum:

      Forum: News forum
      3 posts since last login
      6 total unread

      seems a bit inconsistent - using "posts" in the first line and "total" in the second

      • also the way this is structured makes it hard to theme - (line break instead of div for "total unread" line)

      suggested replacement:
      Forum: News Forum
      6 unread posts (3 since last login)

      I plan to submit a patch to at least remove the line break and use a div so that a theme designer can have better control over it.

        Activity

        Hide
        Dan Marsden added a comment -

        adding Helen - do you have any feedback on this too? - thanks!

        Show
        Dan Marsden added a comment - adding Helen - do you have any feedback on this too? - thanks!
        Hide
        Dan Marsden added a comment -

        ok - here's a patch that allows a theme designer to target the elements properly - this patch doesn't change existing behaviour and should make it display the same as it is:
        https://github.com/danmarsden/moodle/compare/master...m20_MDL-26957_forum_overview

        The patch puts a span around the "since last login" part and a div around the "total unread" so that it displays exactly the same as it does without requiring css changes to everyone unless a theme designer changes it.

        Personally I think the way it displays now is a bit weird anyway and we should change the way it reads to:
        6 unread posts (3 since last login)

        but to make this change probably requires a few other people to agree with me/votes etc - so In the meantime I'll file a pull request for the above low impact change.

        Show
        Dan Marsden added a comment - ok - here's a patch that allows a theme designer to target the elements properly - this patch doesn't change existing behaviour and should make it display the same as it is: https://github.com/danmarsden/moodle/compare/master...m20_MDL-26957_forum_overview The patch puts a span around the "since last login" part and a div around the "total unread" so that it displays exactly the same as it does without requiring css changes to everyone unless a theme designer changes it. Personally I think the way it displays now is a bit weird anyway and we should change the way it reads to: 6 unread posts (3 since last login) but to make this change probably requires a few other people to agree with me/votes etc - so In the meantime I'll file a pull request for the above low impact change.
        Hide
        Dan Marsden added a comment -

        adding Mike as a watcher - might have an opinion on this too!

        Show
        Dan Marsden added a comment - adding Mike as a watcher - might have an opinion on this too!
        Hide
        Helen Foster added a comment -

        Dan, thanks for your suggested improvement which sounds good to me! As you've already submitted a pull request, I'm resolving this issue.

        Show
        Helen Foster added a comment - Dan, thanks for your suggested improvement which sounds good to me! As you've already submitted a pull request, I'm resolving this issue.
        Hide
        Dan Marsden added a comment -

        Thanks Helen - I didn't resolve it earlier as the pull request only solves my problem of needing to be able to theme it better - it still looks weird!

        If you're in agreement that the text should change to:
        6 unread posts (3 since last login)

        then the existing Pull request should probably get rejected and I'll submit a fix to change the way the text is displayed.

        Show
        Dan Marsden added a comment - Thanks Helen - I didn't resolve it earlier as the pull request only solves my problem of needing to be able to theme it better - it still looks weird! If you're in agreement that the text should change to: 6 unread posts (3 since last login) then the existing Pull request should probably get rejected and I'll submit a fix to change the way the text is displayed.
        Hide
        Helen Foster added a comment -

        Yes, I think '6 unread posts (3 since last login)' is much better. Thanks for working on this Dan.

        Show
        Helen Foster added a comment - Yes, I think '6 unread posts (3 since last login)' is much better. Thanks for working on this Dan.
        Hide
        Helen Foster added a comment -

        Thanks Dan

        Show
        Helen Foster added a comment - Thanks Dan

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: