Moodle
  1. Moodle
  2. MDL-26958

In the standard 'Binarius' theme, hidden items are not greyed out. This is very confusing for the teacher.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: Themes
    • Labels:
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Rank:
      16682

      Description

      Not quite a bug, but this seems inconsistent with every other Moodle theme I've used. When I hide something in the 'Binarius' theme, the title is not greyed out as I would expect. I know it's a trivial detail, but I think Moodle users would greatly appreciate having a consistent behavior for hidden activities and resources.

      Thank you very much!

      1. dim.patch
        0.3 kB
        Thomas Lake
      1. Binarius Theme.jpg
        10 kB
      2. Canvas Theme.jpg
        10 kB

        Issue Links

          Activity

          Hide
          Helen Foster added a comment -

          Andrew, thanks for your report. I've voted for this issue to be fixed.

          Show
          Helen Foster added a comment - Andrew, thanks for your report. I've voted for this issue to be fixed.
          Hide
          Thomas Lake added a comment -

          The problem seems to be that the binarius theme redefines styles for a:visited and a:link, overriding the rules defined in base/style/core.css

          The attached patch solves this by adding the appropriate rules in binarius/style/core.css

          Show
          Thomas Lake added a comment - The problem seems to be that the binarius theme redefines styles for a:visited and a:link, overriding the rules defined in base/style/core.css The attached patch solves this by adding the appropriate rules in binarius/style/core.css
          Hide
          Mary Evans added a comment -

          I've tested this and found that if this line (which is taken from Standard theme in Moodle 1.9) is added to Base theme's core.css all links are dimmed, as all CORE themes use Base as a parent theme, so no need to add patch to individual themes.
          The patch is actually in Base theme already, but the following aren't.

          a.dimmed:link,
          a.dimmed:visited

          { color:#AAAAAA; }

          Hopefully fixing this ready for next weekly update.
          Thanks

          Show
          Mary Evans added a comment - I've tested this and found that if this line (which is taken from Standard theme in Moodle 1.9) is added to Base theme's core.css all links are dimmed, as all CORE themes use Base as a parent theme, so no need to add patch to individual themes. The patch is actually in Base theme already, but the following aren't. a.dimmed:link, a.dimmed:visited { color:#AAAAAA; } Hopefully fixing this ready for next weekly update. Thanks
          Hide
          Andrew Davis added a comment - - edited

          PULL-675

          I have the feeling there should be 2 pull requests. One for master (ie Moodle 2.1) and one for MOODLE_20_STABLE (ie Moodle 2.0.x).

          Show
          Andrew Davis added a comment - - edited PULL-675 I have the feeling there should be 2 pull requests. One for master (ie Moodle 2.1) and one for MOODLE_20_STABLE (ie Moodle 2.0.x).
          Hide
          Mary Evans added a comment - - edited

          The patch for this was added to Base theme, and as a result should now fix all CORE themes with the same problem.

          Show
          Mary Evans added a comment - - edited The patch for this was added to Base theme, and as a result should now fix all CORE themes with the same problem.
          Hide
          Andrew Johnson added a comment -

          Thank you very much Mary (and all Moodle contributors) The themes are looking good!

          Show
          Andrew Johnson added a comment - Thank you very much Mary (and all Moodle contributors) The themes are looking good!
          Hide
          Tim Hunt added a comment -

          Just correcting bogus fix-for version.

          Show
          Tim Hunt added a comment - Just correcting bogus fix-for version.

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: