Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26979

custom menu :: IEs overwrite theme CSS with YUI CSS

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1.1, 2.2
    • Fix Version/s: 2.2
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      Testet in IE8 and IE9
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Browse to Settings > Appearance > Theme settings
      3. Enable theme change on URL
      4. Add a custom menu (just copy paste the example)
      5. Test each core theme in Firefox, Chrome + IE.
      6. Check that in each the custommenu looks consistent. It doesn't have to be perfect the aim of these changes is to simplify CSS and improve consistency.
      Show
      Log in as an admin Browse to Settings > Appearance > Theme settings Enable theme change on URL Add a custom menu (just copy paste the example) Test each core theme in Firefox, Chrome + IE. Check that in each the custommenu looks consistent. It doesn't have to be perfect the aim of these changes is to simplify CSS and improve consistency.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-26979-master
    • Pull Master Diff URL:

      Description

      In the IE browsers CSS rules set in the theme are overwritten by the YUI CSS for the custom menu.

      You can see this bug in the "Fusion" Moodle 2 theme when you compare the menu in IE and for example Firefox.

      I tried to understand what happens but have had no luck. My guess is that the YUI CSS which is "lazy loaded" for the menu after the theme CSS is not correctly handled by IE. The link is placed before the theme CSS links but the CSS is rendered after the theme CSS overwriting the rules.

      I did not confirm but I guess the bug not only influences the custom menu but all "lazy loaded" YUI CSS in Moodle 2.

      The custom menu is not usable with this bug, therefore I have set the priority to critical.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28955 Missing arrow for custom menu sub-content in Nimble theme

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-28941 custom menu :: IEs overwrite theme CSS with YUI CSS (backport of MDL-26979)

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              urshunkler Urs Hunkler
              Peer reviewer:
              Andrew Davis
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/11