Moodle
  1. Moodle
  2. MDL-26998

Wiki should store coursemoudle object in page_wiki class

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.6
    • Component/s: Wiki (2.x)
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisites

      • Have a course with at least two groups created.

      General test of Wiki

      • Create a new wiki activity.
      • Test the wiki with
        • Separate groups
        • Visible groups
        • No groups
      • Test creating, and editing with:
        • A teacher
        • A student.

      Make sure no errors are displayed

      Show
      Prerequisites Have a course with at least two groups created. General test of Wiki Create a new wiki activity. Test the wiki with Separate groups Visible groups No groups Test creating, and editing with: A teacher A student. Make sure no errors are displayed
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-26998-master
    • Rank:
      16630

      Description

      Wiki module should avoid using $PAGE->cm in function..

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Raising to critical. I think this is a good follow-up of MDL-26213 (where it was detected), so +1 to be included in next sprint.

          Show
          Eloy Lafuente (stronk7) added a comment - Raising to critical. I think this is a good follow-up of MDL-26213 (where it was detected), so +1 to be included in next sprint.
          Hide
          Rajesh Taneja added a comment -

          Thanks for fixing this Adrian,

          Few minor things you might want to consider before pushing forward:

          1. #L0R90 - object should be stdClass
          2. #L0R294 - Might want to get rid of comment

          Rest all look good. Feel free to push it for integration, when ready.

          Show
          Rajesh Taneja added a comment - Thanks for fixing this Adrian, Few minor things you might want to consider before pushing forward: #L0R90 - object should be stdClass #L0R294 - Might want to get rid of comment Rest all look good. Feel free to push it for integration, when ready.
          Hide
          Adrian Greeve added a comment -

          Thanks for the review Raj,

          I've made those changes. Submitting for integration.

          Show
          Adrian Greeve added a comment - Thanks for the review Raj, I've made those changes. Submitting for integration.
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Looks like this is for master only, while we're on-sync i'm holding this.

          Show
          Dan Poltawski added a comment - Looks like this is for master only, while we're on-sync i'm holding this.
          Hide
          Sam Hemelryk added a comment -

          Definitely looks like master only - any objections to that guys?

          Show
          Sam Hemelryk added a comment - Definitely looks like master only - any objections to that guys?
          Hide
          Adrian Greeve added a comment -

          No objections. Master only please.

          Show
          Adrian Greeve added a comment - No objections. Master only please.
          Hide
          Sam Hemelryk added a comment -

          Thanks Adrian - this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Adrian - this has been integrated now.
          Hide
          Andrew Davis added a comment -

          Raised MDL-40244

          Show
          Andrew Davis added a comment - Raised MDL-40244
          Hide
          Andrew Davis added a comment - - edited

          "Make sure no errors are displayed"

          Adrian, should I leave all of those warnings in that separate issue or should they be fixed here? This does appear to be working aside from the issues I've listed in the new MDL.

          Show
          Andrew Davis added a comment - - edited "Make sure no errors are displayed" Adrian, should I leave all of those warnings in that separate issue or should they be fixed here? This does appear to be working aside from the issues I've listed in the new MDL.
          Hide
          Andrew Davis added a comment -

          Passing as those assorted messages are apparently unrelated.

          Show
          Andrew Davis added a comment - Passing as those assorted messages are apparently unrelated.
          Hide
          Adrian Greeve added a comment -

          perhaps stating "Make sure no errors are displayed" is a tad too ambitious for wiki module.

          Thanks Andrew.

          Show
          Adrian Greeve added a comment - perhaps stating "Make sure no errors are displayed" is a tad too ambitious for wiki module. Thanks Andrew.
          Hide
          Dan Poltawski added a comment -

          Thanks for your contributions!

          _main:
          @ BB#0:
                  push    {r7, lr}
                  mov     r7, sp
                  sub     sp, #4
                  movw    r0, :lower16:(L_.str-(LPC0_0+4))
                  movt    r0, :upper16:(L_.str-(LPC0_0+4))
          LPC0_0:
                  add     r0, pc
                  bl      _printf
                  movs    r1, #0
                  movt    r1, #0
                  str     r0, [sp]                @ 4-byte Spill
                  mov     r0, r1
                  add     sp, #4
                  pop     {r7, pc}
          
                  .section        __TEXT,__cstring,cstring_literals
          L_.str:                                 @ @.str
                  .asciz   "This code is now upstream!"
          
          Show
          Dan Poltawski added a comment - Thanks for your contributions! _main: @ BB#0: push {r7, lr} mov r7, sp sub sp, #4 movw r0, :lower16:(L_.str-(LPC0_0+4)) movt r0, :upper16:(L_.str-(LPC0_0+4)) LPC0_0: add r0, pc bl _printf movs r1, #0 movt r1, #0 str r0, [sp] @ 4- byte Spill mov r0, r1 add sp, #4 pop {r7, pc} .section __TEXT,__cstring,cstring_literals L_.str: @ @.str .asciz "This code is now upstream!"

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: