Moodle
  1. Moodle
  2. MDL-27024

Patch to make comments API more flexible and less dependent on the comments block

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.1
    • Component/s: Comments
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE

      Description

      The attached patch is designed to make the comments API more flexible and usable by moving some of its hard coded options to proper options.
      The hard coded checks for the comments block can then be replaced by checks for these options.
      It also moves some of the smarts of the output function into separate functions.

      This is required for the new plugins plugin (replacement for the modules and plugins database).

      Cheers
      Sam

        Gliffy Diagrams

          Activity

          Hide
          Sam Hemelryk added a comment -

          Hi Dongsheng,

          Would you be able to look at the changes I want to make as part of this issue?
          You can check it out at on my github account:
          Repo URL: https://github.com/samhemelryk/moodle
          Branch: wip-MDL-27024
          Diff URL: https://github.com/samhemelryk/moodle/compare/master...wip-MDL-27024

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Dongsheng, Would you be able to look at the changes I want to make as part of this issue? You can check it out at on my github account: Repo URL: https://github.com/samhemelryk/moodle Branch: wip- MDL-27024 Diff URL: https://github.com/samhemelryk/moodle/compare/master...wip-MDL-27024 Cheers Sam
          Hide
          Dongsheng Cai added a comment -

          Hi Sam

          Sorry for taking long to response your patch.

          I cannot see any problem of your improvement, it fixed the hack to for comment_block, looks very good, my +1 to PULL Request this.

          Thanks

          Show
          Dongsheng Cai added a comment - Hi Sam Sorry for taking long to response your patch. I cannot see any problem of your improvement, it fixed the hack to for comment_block, looks very good, my +1 to PULL Request this. Thanks
          Hide
          Sam Hemelryk added a comment -

          Created PULL-639 and PULL-640

          Show
          Sam Hemelryk added a comment - Created PULL-639 and PULL-640

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: