Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27034

Simplify xhprof_table_sql implementation

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1
    • Fix Version/s: 2.0.3
    • Component/s: Libraries
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Once all the improvements present @ MDL-26425 have been committed, it will be possible to simplify a bit the xhprof_table_sql implementation by using standard build_table() method and, instead, override the newly available get_row_class() for stylizing rows.

      Right now the improvements are only available @ 20_STABLE so the initial patch will be for it. Once the change is available @ master, the patch will be applied there and this issue requested for pull.

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                stronk7 Eloy Lafuente (stronk7)
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/May/11