Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27040

get_users_by_capability generates u.id IN () when no users have accessallgroups

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1, 2.2
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a course with some groups containing teachers and students
      2. override the teacher permission, so they don't have accessallgroups
      3. Create a quiz in separate groups mode, and attempt it as a teacher.
      4. Try to view the quiz reports as a teacher.

      Show
      1. Create a course with some groups containing teachers and students 2. override the teacher permission, so they don't have accessallgroups 3. Create a quiz in separate groups mode, and attempt it as a teacher. 4. Try to view the quiz reports as a teacher.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      See http://moodle.org/mod/forum/post.php?reply=755514.

      It is possible to get the get_users_by_capability call in quiz_send_notification_emails to generate the SQL "OR u.id IN ()".

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!
            (master, 21 and 20 stables)

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (master, 21 and 20 stables)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Incorporated upstream, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Incorporated upstream, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11