get_users_by_capability generates u.id IN () when no users have accessallgroups

Testing Instructions:

Hide

1. Create a course with some groups containing teachers and students
2. override the teacher permission, so they don't have accessallgroups
3. Create a quiz in separate groups mode, and attempt it as a teacher.
4. Try to view the quiz reports as a teacher.

Show
1. Create a course with some groups containing teachers and students 2. override the teacher permission, so they don't have accessallgroups 3. Create a quiz in separate groups mode, and attempt it as a teacher. 4. Try to view the quiz reports as a teacher.
Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-27040~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-27040

It is possible to get the get_users_by_capability call in quiz_send_notification_emails to generate the SQL "OR u.id IN ()".

is duplicated by

MDL-27740 dmlreadexception error on close of quiz attempt

Ascending order - Click to sort in descending order

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 07/Jul/11 1:27 AM

Integrated, thanks!
(master, 21 and 20 stables)

Show

Eloy Lafuente (stronk7) added a comment - 07/Jul/11 1:27 AM Integrated, thanks! (master, 21 and 20 stables)

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 09/Jul/11 12:26 AM

Incorporated upstream, thanks!

Show

Eloy Lafuente (stronk7) added a comment - 09/Jul/11 12:26 AM Incorporated upstream, thanks!

Vote (0)

Watch (1)