Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27063

Canvas theme says tt { display: block; }. That is really bad

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: STABLE backlog
    • Component/s: Themes
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      <tt> is an inline HTML tag. Setting all <tt> tags to display: block; in canvas's text.css seems crazy to me. Please can we stop doing that?

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            ptrkmkl Patrick Malley added a comment -

            Mary, could you look into this, please?

            Show
            ptrkmkl Patrick Malley added a comment - Mary, could you look into this, please?
            Hide
            korpelainen Mauno Korpelainen added a comment -

            I tried (twice) to attach a screenshot about current "canvas way" & correct way to use teletype text (tt tags) but they vanished...I wonder why ???

            Anyway, this is really easy to fix - you just need to delete line

            display:block;

            from

            tt {
            display: block;
            margin: 1.5em 0;
            line-height: 1.5;
            }

            in files theme/canvas/style/text.css and theme/canvas/style/editor.css

            Show
            korpelainen Mauno Korpelainen added a comment - I tried (twice) to attach a screenshot about current "canvas way" & correct way to use teletype text (tt tags) but they vanished...I wonder why ??? Anyway, this is really easy to fix - you just need to delete line display:block; from tt { display: block; margin: 1.5em 0; line-height: 1.5; } in files theme/canvas/style/text.css and theme/canvas/style/editor.css
            Hide
            lazydaisy Mary Evans added a comment -

            Will fix this now.

            Show
            lazydaisy Mary Evans added a comment - Will fix this now.
            Hide
            lazydaisy Mary Evans added a comment -

            Done the fixes and put in a Pull Request. I also tidied up the css for pre, code, tt as all three use the same values for margin, line-height and font-family.

            Show
            lazydaisy Mary Evans added a comment - Done the fixes and put in a Pull Request. I also tidied up the css for pre, code, tt as all three use the same values for margin, line-height and font-family.
            Hide
            timhunt Tim Hunt added a comment -

            Yay! thank you. That was quick.

            Show
            timhunt Tim Hunt added a comment - Yay! thank you. That was quick.
            Hide
            lazydaisy Mary Evans added a comment -

            Don't speak too soon, Tim, although I did the commit, but in my eagerness to get this done last night I forgot to push the patch to my github account! LOL All done now, Hopefully Sam is dealing with it, so all being well should go thru OK.

            Cheers
            Mary

            Show
            lazydaisy Mary Evans added a comment - Don't speak too soon, Tim, although I did the commit, but in my eagerness to get this done last night I forgot to push the patch to my github account! LOL All done now, Hopefully Sam is dealing with it, so all being well should go thru OK. Cheers Mary

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: