Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27072

Quiz reports should use enroled users code, not get_users_by_capability

    Details

    • Testing Instructions:
      Hide
      1. Create a course, make visible and add 3 groups.
      2. Create at least 4 students (s1 to s4).
      3. Enrol these students on the course.
      4. Put the students into two groups (leave one group empty).
      5. Create quiz1, with visible groups.
      6. Add an Essay question (Write something here...) - for manual marking
      7. Add a True/False question (Choose one...) - for auto marking
      8. Login as s1, start quiz1, answer questions correctly.
      9. Login as s2, answer one question correctly.
      10. Login as s3, start quiz but do not answer any questions.
      11. Login as s4, do not start quiz.
      12. Login as admin.
      13. Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
      14. Be sure to test features on the Quiz Grades and Responses reports, such as selecting attempts and deleting them, or re-grading attempts.
      15. The above will prove that nothing is broken.
      16. Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
      Show
      Create a course, make visible and add 3 groups. Create at least 4 students (s1 to s4). Enrol these students on the course. Put the students into two groups (leave one group empty). Create quiz1, with visible groups. Add an Essay question (Write something here...) - for manual marking Add a True/False question (Choose one...) - for auto marking Login as s1, start quiz1, answer questions correctly. Login as s2, answer one question correctly. Login as s3, start quiz but do not answer any questions. Login as s4, do not start quiz. Login as admin. Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page. Be sure to test features on the Quiz Grades and Responses reports, such as selecting attempts and deleting them, or re-grading attempts. The above will prove that nothing is broken. Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      wip-MDL-27072-master

      Description

      This is spun off from MDL-27071.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  5 Vote for this issue
                  Watchers:
                  12 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/16