Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27072

Quiz reports should use enroled users code, not get_users_by_capability

    Details

    • Testing Instructions:
      Hide
      1. Create a course, make visible and add 3 groups.
      2. Create at least 4 students (s1 to s4).
      3. Enrol these students on the course.
      4. Put the students into two groups (leave one group empty).
      5. Create quiz1, with visible groups.
      6. Add an Essay question (Write something here...) - for manual marking
      7. Add a True/False question (Choose one...) - for auto marking
      8. Login as s1, start quiz1, answer questions correctly.
      9. Login as s2, answer one question correctly.
      10. Login as s3, start quiz but do not answer any questions.
      11. Login as s4, do not start quiz.
      12. Login as admin.
      13. Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
      14. Be sure to test features on the Quiz Grades and Responses reports, such as selecting attempts and deleting them, or re-grading attempts.
      15. The above will prove that nothing is broken.
      16. Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
      Show
      Create a course, make visible and add 3 groups. Create at least 4 students (s1 to s4). Enrol these students on the course. Put the students into two groups (leave one group empty). Create quiz1, with visible groups. Add an Essay question (Write something here...) - for manual marking Add a True/False question (Choose one...) - for auto marking Login as s1, start quiz1, answer questions correctly. Login as s2, answer one question correctly. Login as s3, start quiz but do not answer any questions. Login as s4, do not start quiz. Login as admin. Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page. Be sure to test features on the Quiz Grades and Responses reports, such as selecting attempts and deleting them, or re-grading attempts. The above will prove that nothing is broken. Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      wip-MDL-27072-master

      Description

      This is spun off from MDL-27071.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              timhunt Tim Hunt created issue -
              timhunt Tim Hunt made changes -
              Field Original Value New Value
              Link This issue has a non-specific relationship to MDL-27071 [ MDL-27071 ]
              dougiamas Martin Dougiamas made changes -
              Workflow MDL Workflow [ 69073 ] MDL Full Workflow [ 76279 ]
              timhunt Tim Hunt made changes -
              Link This issue is duplicated by MDL-34770 [ MDL-34770 ]
              matt.clarkson Matt Clarkson made changes -
              timhunt Tim Hunt made changes -
              Status Open [ 1 ] Peer review in progress [ 10013 ]
              Peer reviewer timhunt
              timhunt Tim Hunt made changes -
              Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
              matt.clarkson Matt Clarkson made changes -
              Pull Master Diff URL https://github.com/matt-catalyst/moodle/compare/MDL-27072
              Pull Master Branch MDL-27072
              Pull from Repository git@github.com:matt-catalyst/moodle.git
              timhunt Tim Hunt made changes -
              Link This issue is blocked by MDL-31243 [ MDL-31243 ]
              timhunt Tim Hunt made changes -
              Status Development in progress [ 3 ] Open [ 1 ]
              timhunt Tim Hunt made changes -
              Assignee Tim Hunt [ timhunt ]
              danmarsden Dan Marsden made changes -
              Labels triaged CatalystIT Partner triaged
              danmarsden Dan Marsden made changes -
              Labels CatalystIT Partner triaged CatalystIT Partner patch triaged
              timhunt Tim Hunt made changes -
              Labels CatalystIT Partner patch triaged CatalystIT Partner triaged
              danmarsden Dan Marsden made changes -
              Assignee Dan Marsden [ danmarsden ]
              timhunt Tim Hunt made changes -
              Link This issue is duplicated by MDL-40398 [ MDL-40398 ]
              danmarsden Dan Marsden made changes -
              Assignee Dan Marsden [ danmarsden ]
              timhunt Tim Hunt made changes -
              Link This issue is duplicated by MDL-53199 [ MDL-53199 ]
              jb23347 John Beedell made changes -
              Assignee John Beedell [ jb23347 ]
              jb23347 John Beedell made changes -
              Status Open [ 1 ] Waiting for peer review [ 10012 ]
              Pull from Repository git@github.com:matt-catalyst/moodle.git https://github.com/Beedell/moodle.git
              Pull Master Diff URL https://github.com/matt-catalyst/moodle/compare/MDL-27072 https://github.com/moodle/moodle/compare/master...Beedell:wip-MDL-27072-MDL-31243-master
              Testing Instructions Create a course, visible with visible groups.
              Create at least 4 students (s1 to s4).
              Enrol these students on the course.
              Put the students into two groups (Group A, and Group B).
              Create quiz1, visible with visible groups.
              Add an Essay question (Write something here...)
              Add a True/False question (Choose one...)
              Login as s1, start quiz1, answer questions correctly.
              Login as s2, answer one question correctly.
              Login as s3, start quiz but do not answer any questions.
              Login as s4, do not start quiz.
              Login as admin.
              Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              jb23347 John Beedell made changes -
              Pull Master Branch MDL-27072 wip-MDL-27072-MDL-31243-master
              cibot CiBoT made changes -
              Labels CatalystIT Partner triaged CatalystIT Partner ci triaged
              jb23347 John Beedell made changes -
              Labels CatalystIT Partner ci triaged CatalystIT Partner triaged
              cibot CiBoT made changes -
              Labels CatalystIT Partner triaged CatalystIT Partner ci triaged
              jb23347 John Beedell made changes -
              Status Waiting for peer review [ 10012 ] Development in progress [ 3 ]
              cibot CiBoT made changes -
              Labels CatalystIT Partner ci triaged CatalystIT Partner triaged
              cibot CiBoT made changes -
              Labels CatalystIT Partner triaged CatalystIT Partner ci triaged
              jb23347 John Beedell made changes -
              Labels CatalystIT Partner ci triaged CatalystIT Partner triaged
              cibot CiBoT made changes -
              Labels CatalystIT Partner triaged CatalystIT Partner ci triaged
              timhunt Tim Hunt made changes -
              Remaining Estimate 0 minutes [ 0 ]
              Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
              timhunt Tim Hunt made changes -
              Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
              timhunt Tim Hunt made changes -
              Labels CatalystIT Partner ci triaged CatalystIT Partner api_change ci release_notes triaged
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change ci release_notes triaged CatalystIT Partner api_change release_notes triaged
              jb23347 John Beedell made changes -
              Testing Instructions Create a course, visible with visible groups.
              Create at least 4 students (s1 to s4).
              Enrol these students on the course.
              Put the students into two groups (Group A, and Group B).
              Create quiz1, visible with visible groups.
              Add an Essay question (Write something here...)
              Add a True/False question (Choose one...)
              Login as s1, start quiz1, answer questions correctly.
              Login as s2, answer one question correctly.
              Login as s3, start quiz but do not answer any questions.
              Login as s4, do not start quiz.
              Login as admin.
              Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              Create a course, visible with visible groups.
              Create at least 4 students (s1 to s4).
              Enrol these students on the course.
              Put the students into two groups (Group A, and Group B).
              Create quiz1, visible with visible groups.
              Add an Essay question (Write something here...)
              Add a True/False question (Choose one...)
              Login as s1, start quiz1, answer questions correctly.
              Login as s2, answer one question correctly.
              Login as s3, start quiz but do not answer any questions.
              Login as s4, do not start quiz.
              Login as admin.
              Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              The above will prove that nothing is broken. But to prove that this change actually works then it is necessary to start with a course created by
              jb23347 John Beedell made changes -
              Testing Instructions Create a course, visible with visible groups.
              Create at least 4 students (s1 to s4).
              Enrol these students on the course.
              Put the students into two groups (Group A, and Group B).
              Create quiz1, visible with visible groups.
              Add an Essay question (Write something here...)
              Add a True/False question (Choose one...)
              Login as s1, start quiz1, answer questions correctly.
              Login as s2, answer one question correctly.
              Login as s3, start quiz but do not answer any questions.
              Login as s4, do not start quiz.
              Login as admin.
              Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              The above will prove that nothing is broken. But to prove that this change actually works then it is necessary to start with a course created by
              Create a course, visible with visible groups.
              Create at least 4 students (s1 to s4).
              Enrol these students on the course.
              Put the students into two groups (Group A, and Group B).
              Create quiz1, visible with visible groups.
              Add an Essay question (Write something here...)
              Add a True/False question (Choose one...)
              Login as s1, start quiz1, answer questions correctly.
              Login as s2, answer one question correctly.
              Login as s3, start quiz but do not answer any questions.
              Login as s4, do not start quiz.
              Login as admin.
              Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              The above will prove that nothing is broken.
              But to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these changes many of the quiz reports do not work.
              jb23347 John Beedell made changes -
              Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change release_notes triaged CatalystIT Partner api_change ci release_notes triaged
              jb23347 John Beedell made changes -
              Labels CatalystIT Partner api_change ci release_notes triaged CatalystIT Partner api_change release_notes triaged
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change release_notes triaged CatalystIT Partner api_change ci release_notes triaged
              timhunt Tim Hunt made changes -
              Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
              timhunt Tim Hunt made changes -
              Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change ci release_notes triaged CatalystIT Partner api_change release_notes triaged
              jb23347 John Beedell made changes -
              Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
              Testing Instructions Create a course, visible with visible groups.
              Create at least 4 students (s1 to s4).
              Enrol these students on the course.
              Put the students into two groups (Group A, and Group B).
              Create quiz1, visible with visible groups.
              Add an Essay question (Write something here...)
              Add a True/False question (Choose one...)
              Login as s1, start quiz1, answer questions correctly.
              Login as s2, answer one question correctly.
              Login as s3, start quiz but do not answer any questions.
              Login as s4, do not start quiz.
              Login as admin.
              Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              The above will prove that nothing is broken.
              But to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these changes many of the quiz reports do not work.
              Create a course, make visible and add 3 groups.
              Create at least 4 students (s1 to s4).
              Enrol these students on the course.
              Put the students into two groups (leave one group empty).
              Create quiz1, with visible groups.
              Add an Essay question (Write something here...) - for manual marking
              Add a True/False question (Choose one...) - for auto marking
              Login as s1, start quiz1, answer questions correctly.
              Login as s2, answer one question correctly.
              Login as s3, start quiz but do not answer any questions.
              Login as s4, do not start quiz.
              Login as admin.
              Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              The above will prove that nothing is broken.
              Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change release_notes triaged CatalystIT Partner api_change ci release_notes triaged
              timhunt Tim Hunt made changes -
              Testing Instructions Create a course, make visible and add 3 groups.
              Create at least 4 students (s1 to s4).
              Enrol these students on the course.
              Put the students into two groups (leave one group empty).
              Create quiz1, with visible groups.
              Add an Essay question (Write something here...) - for manual marking
              Add a True/False question (Choose one...) - for auto marking
              Login as s1, start quiz1, answer questions correctly.
              Login as s2, answer one question correctly.
              Login as s3, start quiz but do not answer any questions.
              Login as s4, do not start quiz.
              Login as admin.
              Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              The above will prove that nothing is broken.
              Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
              # Create a course, make visible and add 3 groups.
              # Create at least 4 students (s1 to s4).
              # Enrol these students on the course.
              # Put the students into two groups (leave one group empty).
              # Create quiz1, with visible groups.
              # Add an Essay question (Write something here...) - for manual marking
              # Add a True/False question (Choose one...) - for auto marking
              # Login as s1, start quiz1, answer questions correctly.
              # Login as s2, answer one question correctly.
              # Login as s3, start quiz but do not answer any questions.
              # Login as s4, do not start quiz.
              # Login as admin.
              # Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              # The above will prove that nothing is broken.
              # Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
              timhunt Tim Hunt made changes -
              Testing Instructions # Create a course, make visible and add 3 groups.
              # Create at least 4 students (s1 to s4).
              # Enrol these students on the course.
              # Put the students into two groups (leave one group empty).
              # Create quiz1, with visible groups.
              # Add an Essay question (Write something here...) - for manual marking
              # Add a True/False question (Choose one...) - for auto marking
              # Login as s1, start quiz1, answer questions correctly.
              # Login as s2, answer one question correctly.
              # Login as s3, start quiz but do not answer any questions.
              # Login as s4, do not start quiz.
              # Login as admin.
              # Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              # The above will prove that nothing is broken.
              # Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
              # Create a course, make visible and add 3 groups.
              # Create at least 4 students (s1 to s4).
              # Enrol these students on the course.
              # Put the students into two groups (leave one group empty).
              # Create quiz1, with visible groups.
              # Add an Essay question (Write something here...) - for manual marking
              # Add a True/False question (Choose one...) - for auto marking
              # Login as s1, start quiz1, answer questions correctly.
              # Login as s2, answer one question correctly.
              # Login as s3, start quiz but do not answer any questions.
              # Login as s4, do not start quiz.
              # Login as admin.
              # Check all pages of the quiz reports (Administration > Quiz administration > Results) and every option with each page.
              # Be sure to test features on the Quiz Grades and Responses reports, such as selecting attempts and deleting them, or re-grading attempts.
              # The above will prove that nothing is broken.
              # Now to prove that this change actually works it is necessary to start with a course created by admin/tool/generator/maketestcourse.php with 50,000 enrolled users (look at the code to work out the setting required), and then do all the steps above on that course. Without these code changes many of the quiz reports do not work.
              timhunt Tim Hunt made changes -
              Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
              cibot CiBoT made changes -
              Status Waiting for integration review [ 10010 ] Waiting for integration review [ 10010 ]
              Integration priority 0
              Original Estimate 0 minutes [ 0 ]
              cibot CiBoT made changes -
              Status Waiting for integration review [ 10010 ] Waiting for integration review [ 10010 ]
              Currently in integration Yes [ 10041 ]
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change ci release_notes triaged CatalystIT Partner api_change release_notes triaged
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change release_notes triaged CatalystIT Partner api_change ci release_notes triaged
              stronk7 Eloy Lafuente (stronk7) made changes -
              Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
              Integrator Eloy Lafuente (stronk7) [ stronk7 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Status Integration review in progress [ 10004 ] Reopened [ 4 ]
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change ci release_notes triaged CatalystIT Partner api_change release_notes triaged
              cibot CiBoT made changes -
              Status Reopened [ 4 ] Reopened [ 4 ]
              Fix Version/s DEV backlog [ 10464 ]
              Currently in integration Yes [ 10041 ]
              timhunt Tim Hunt made changes -
              Status Reopened [ 4 ] Peer review in progress [ 10013 ]
              timhunt Tim Hunt made changes -
              Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
              jb23347 John Beedell made changes -
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change release_notes triaged CatalystIT Partner api_change ci release_notes triaged
              jb23347 John Beedell made changes -
              Status Waiting for peer review [ 10012 ] Development in progress [ 3 ]
              jb23347 John Beedell made changes -
              Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
              Pull Master Branch wip-MDL-31243-master wip-MDL-27072-master
              jb23347 John Beedell made changes -
              Labels CatalystIT Partner api_change ci release_notes triaged CatalystIT Partner api_change release_notes triaged
              cibot CiBoT made changes -
              Labels CatalystIT Partner api_change release_notes triaged CatalystIT Partner api_change ci release_notes triaged
              timhunt Tim Hunt made changes -
              Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
              Currently in integration Yes [ 10041 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
              Affects Version/s 3.2 [ 15258 ]
              Fix Version/s 3.2 [ 15258 ]
              rajeshtaneja Rajesh Taneja made changes -
              Tester Damyon Wiese [ damyon ]
              damyon Damyon Wiese made changes -
              Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
              damyon Damyon Wiese made changes -
              Status Testing in progress [ 10011 ] Tested [ 10006 ]
              rajeshtaneja Rajesh Taneja made changes -
              Status Tested [ 10006 ] Problem during testing [ 10007 ]
              dmonllao David Monllaó made changes -
              Status Problem during testing [ 10007 ] Waiting for testing [ 10005 ]
              rajeshtaneja Rajesh Taneja made changes -
              Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
              rajeshtaneja Rajesh Taneja made changes -
              Status Testing in progress [ 10011 ] Tested [ 10006 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Status Tested [ 10006 ] Closed [ 6 ]
              Integration date 14/Oct/16
              Currently in integration Yes [ 10041 ]
              Resolution Fixed [ 1 ]
              marina Marina Glancy made changes -
              Labels CatalystIT Partner api_change ci release_notes triaged CatalystIT Partner api_change ci triaged
              poltawski Dan Poltawski made changes -
              Link This issue has a non-specific relationship to MDL-57234 [ MDL-57234 ]

                People

                • Votes:
                  5 Vote for this issue
                  Watchers:
                  12 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/16