Details

    • Testing Instructions:
      1. Login as admin
      2. Purge all caches
      3. Turn on editing mode
      4. Check the roles icon is the same size as the others on the blocks
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Rank:
      16728

      Description

      the roles.gif icon has an other size athn other icons used on course page:
      roles.gif = 16x16 px
      edit.gif = 11x11 px

      All icons should have the same size. I suggest generally 16x16. 11x11 is much to small.

      1. patch.txt
        1 kB
        Navin Pai
      1. icon.png
        3 kB

        Activity

        Hide
        Navin Pai added a comment -

        Just browsing around, I found that there's a 16x16 'edit.gif' icon already present in Moodle. M attaching a patch that I think should fix the error, and display a 16x16 icon instead of the 11x11 icon

        Show
        Navin Pai added a comment - Just browsing around, I found that there's a 16x16 'edit.gif' icon already present in Moodle. M attaching a patch that I think should fix the error, and display a 16x16 icon instead of the 11x11 icon
        Hide
        Navin Pai added a comment -

        Have simply replaced /t/edit.gif by/i/edit.gif ...which is the path of the 16x16 icon

        Change made in

        {install_dir}

        /mod/glossary/settings.php

        Show
        Navin Pai added a comment - Have simply replaced /t/edit.gif by/i/edit.gif ...which is the path of the 16x16 icon Change made in {install_dir} /mod/glossary/settings.php
        Hide
        Helen Foster added a comment -

        I'd not noticed before now that the roles icon is bigger than the others! All the icons next to course activities are 11x11. I'm not sure whether 16x16 would work there.

        Navin, thanks for your patch.

        Show
        Helen Foster added a comment - I'd not noticed before now that the roles icon is bigger than the others! All the icons next to course activities are 11x11. I'm not sure whether 16x16 would work there. Navin, thanks for your patch.
        Hide
        Mauno Korpelainen added a comment -

        The main problem is not in settings of glossary but in lib/blocklib.php and line 990 there which is using

        $controls[] = array('url' => $CFG->wwwroot . '/' . $CFG->admin .
        '/roles/assign.php?contextid=' . $block->context->id . '&returnurl=' . urlencode($return),
        'icon' => 'i/roles', 'caption' => get_string('assignroles', 'role'));

        For some reason folder pix/t does not have a 11x11px roles.gif icon and blocklib is using 16x16px icon from pix/i

        To make all control icons equal size we should add a new 11x11px roles.gif icon to folder pix/t and change the previous code to

        $controls[] = array('url' => $CFG->wwwroot . '/' . $CFG->admin .
        '/roles/assign.php?contextid=' . $block->context->id . '&returnurl=' . urlencode($return),
        'icon' => 't/roles', 'caption' => get_string('assignroles', 'role'));

        If some theme needs to use larger control icons you just need to add all the necessary larger icons (for example 16x16px) to theme/yourtheme/pix_core/t - it's so simple...

        Show
        Mauno Korpelainen added a comment - The main problem is not in settings of glossary but in lib/blocklib.php and line 990 there which is using $controls[] = array('url' => $CFG->wwwroot . '/' . $CFG->admin . '/roles/assign.php?contextid=' . $block->context->id . '&returnurl=' . urlencode($return), 'icon' => 'i/roles', 'caption' => get_string('assignroles', 'role')); For some reason folder pix/t does not have a 11x11px roles.gif icon and blocklib is using 16x16px icon from pix/i To make all control icons equal size we should add a new 11x11px roles.gif icon to folder pix/t and change the previous code to $controls[] = array('url' => $CFG->wwwroot . '/' . $CFG->admin . '/roles/assign.php?contextid=' . $block->context->id . '&returnurl=' . urlencode($return), 'icon' => 't/roles', 'caption' => get_string('assignroles', 'role')); If some theme needs to use larger control icons you just need to add all the necessary larger icons (for example 16x16px) to theme/yourtheme/pix_core/t - it's so simple...
        Hide
        Jason Fowler added a comment -

        I'll be fixing this issue for 2.1 ... it seems to have been fixed for 2.3dev already, I haven't checked 2.2 yet though

        Show
        Jason Fowler added a comment - I'll be fixing this issue for 2.1 ... it seems to have been fixed for 2.3dev already, I haven't checked 2.2 yet though
        Hide
        Jason Fowler added a comment -

        The bug only exists for 2.1 so I will fix for that, 2.0 has been dropped for general bug support

        Show
        Jason Fowler added a comment - The bug only exists for 2.1 so I will fix for that, 2.0 has been dropped for general bug support
        Hide
        Jason Fowler added a comment -

        Code checked in, simple one-line CSS fix, should be really easy for anyone using 2.0 to patch their instances too.

        Show
        Jason Fowler added a comment - Code checked in, simple one-line CSS fix, should be really easy for anyone using 2.0 to patch their instances too.
        Hide
        Dan Poltawski added a comment -

        Makes sense.

        If I were nitpicking i'd match the same order as it is in 2.2 to indicate that its the same (also I prefer the height/width being next to each other) but that is of course irrelevant!

        Show
        Dan Poltawski added a comment - Makes sense. If I were nitpicking i'd match the same order as it is in 2.2 to indicate that its the same (also I prefer the height/width being next to each other) but that is of course irrelevant!
        Hide
        Jason Fowler added a comment -

        I think it's fine the way it is, pushing this through for integration

        Show
        Jason Fowler added a comment - I think it's fine the way it is, pushing this through for integration
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some hours ago...

        the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Jason Fowler added a comment -

        rebased the branch

        Show
        Jason Fowler added a comment - rebased the branch
        Hide
        Sam Hemelryk added a comment -

        Thanks Jason this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Jason this has been integrated now
        Hide
        Jason Fowler added a comment -

        Thanks Sam

        Show
        Jason Fowler added a comment - Thanks Sam
        Hide
        Michael de Raadt added a comment -

        I just added a step to purge caches in the testing instructions.

        Show
        Michael de Raadt added a comment - I just added a step to purge caches in the testing instructions.
        Hide
        Michael de Raadt added a comment -

        Test result: Success!

        Show
        Michael de Raadt added a comment - Test result: Success!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        FCT (fixed, closing, thanks). Ciao

        "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
        ~ Benjamin Disraeli

        Show
        Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: