Just browsing around, I found that there's a 16x16 'edit.gif' icon already present in Moodle. M attaching a patch that I think should fix the error, and display a 16x16 icon instead of the 11x11 icon

Have simply replaced /t/edit.gif by/i/edit.gif ...which is the path of the 16x16 icon

Change made in

/mod/glossary/settings.php

I'd not noticed before now that the roles icon is bigger than the others! All the icons next to course activities are 11x11. I'm not sure whether 16x16 would work there.

Navin, thanks for your patch.

The main problem is not in settings of glossary but in lib/blocklib.php and line 990 there which is using

$controls[] = array('url' => $CFG->wwwroot . '/' . $CFG->admin .
'/roles/assign.php?contextid=' . $block->context->id . '&returnurl=' . urlencode($return),
'icon' => 'i/roles', 'caption' => get_string('assignroles', 'role'));

For some reason folder pix/t does not have a 11x11px roles.gif icon and blocklib is using 16x16px icon from pix/i

To make all control icons equal size we should add a new 11x11px roles.gif icon to folder pix/t and change the previous code to

$controls[] = array('url' => $CFG->wwwroot . '/' . $CFG->admin .
'/roles/assign.php?contextid=' . $block->context->id . '&returnurl=' . urlencode($return),
'icon' => 't/roles', 'caption' => get_string('assignroles', 'role'));

If some theme needs to use larger control icons you just need to add all the necessary larger icons (for example 16x16px) to theme/yourtheme/pix_core/t - it's so simple...

I'll be fixing this issue for 2.1 ... it seems to have been fixed for 2.3dev already, I haven't checked 2.2 yet though

The bug only exists for 2.1 so I will fix for that, 2.0 has been dropped for general bug support

Code checked in, simple one-line CSS fix, should be really easy for anyone using 2.0 to patch their instances too.

Makes sense.

If I were nitpicking i'd match the same order as it is in 2.2 to indicate that its the same (also I prefer the height/width being next to each other) but that is of course irrelevant!

I think it's fine the way it is, pushing this through for integration

Some hours ago...

the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

rebased the branch

Thanks Jason this has been integrated now

Thanks Sam

I just added a step to purge caches in the testing instructions.

Test result: Success!

FCT (fixed, closing, thanks). Ciao

"I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
~ Benjamin Disraeli