Details

    • Testing Instructions:
      Hide

      Note that this issue can be effectively tested together with MDL-26955

      1. Create a folder called 'morethemes' in moodledata directory and set permissions so that the web server can at least read it
      2. Put the following into your config.php: $CFG->themedir = $CFG->dataroot.'/morethemes';
      3. Move a theme folder from $CFG->dirroot/theme/ into the morethemes folders
      4. Go to the theme selector
      5. TEST: make sure that the moved theme is still displayed in the list
      6. TEST: make sure that the name of the theme is displayed correctly
      7. TEST: make sure that when the theme is selected, it works as if it was in the standard location

      Show
      Note that this issue can be effectively tested together with MDL-26955 1. Create a folder called 'morethemes' in moodledata directory and set permissions so that the web server can at least read it 2. Put the following into your config.php: $CFG->themedir = $CFG->dataroot.'/morethemes'; 3. Move a theme folder from $CFG->dirroot/theme/ into the morethemes folders 4. Go to the theme selector 5. TEST: make sure that the moved theme is still displayed in the list 6. TEST: make sure that the name of the theme is displayed correctly 7. TEST: make sure that when the theme is selected, it works as if it was in the standard location
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27116-themedir-config

      Description

      CFG->themedir do not work in 2.0.

      Workaround
      file: /lib/outputlib.php
      Function: function find_theme_location

      REPLACE
      if (file_exists("$CFG->dirroot/theme/$themename/config.php")) {
      $dir = "$CFG->dirroot/theme/$themename";
      WITH
      if (file_exists("$CFG->dirroot/theme/$themename/config.php"))

      { $dir = "$CFG->dirroot/theme/$themename"; }

      elseif (file_exists("$CFG->themedir/$themename/config.php")) {
      $dir = "$CFG->themedir/$themename";

      MDL-26955 will still be an issue.

        Gliffy Diagrams

          Issue Links

            Activity

            Jai Gupta created issue -
            Jai Gupta made changes -
            Field Original Value New Value
            Component/s Lib [ 10096 ]
            Patrick Malley made changes -
            Link This issue will help resolve MDL-26955 [ MDL-26955 ]
            Patrick Malley made changes -
            Assignee Patrick Malley [ ptrkmkl ] moodle.com [ moodle.com ]
            Petr Skoda made changes -
            Assignee moodle.com [ moodle.com ] David Mudrak [ mudrd8mz ]
            Martin Dougiamas made changes -
            Workflow MDL Workflow [ 69142 ] MDL Full Workflow [ 76309 ]
            David Mudrak made changes -
            Link This issue will help resolve MDL-26955 [ MDL-26955 ]
            David Mudrak made changes -
            Link This issue has been marked as being related by MDL-26955 [ MDL-26955 ]
            David Mudrak made changes -
            Status Open [ 1 ] Waiting for review [ 10010 ]
            Pull Master Diff URL https://github.com/mudrd8mz/moodle/compare/master...MDL-27116-themedir-config
            Pull Master Branch MDL-27116-themedir-config
            Pull 2.0 Diff URL https://github.com/mudrd8mz/moodle/compare/MOODLE_20_STABLE...MDL-27116-themedir-config_20_STABLE
            Pull 2.0 Branch MDL-27116-themedir-config_20_STABLE
            Pull from Repository git://github.com/mudrd8mz/moodle.git
            Fix Version/s 2.0.3 [ 10537 ]
            Fix Version/s 2.1 [ 10370 ]
            Martin Dougiamas made changes -
            Testing Instructions Note that this issue can be effectively tested together with MDL-26955

            1. Create a folder called 'morethemes' in moodledata directory and set permissions so that the web server can at least read it
            2. Put the following into your config.php: $CFG->themedir = $CFG->dataroot.'/morethemes';
            3. Move a theme folder from $CFG->dirroot/theme/ into the morethemes folders
            4. Go to the theme selector
            5. TEST: make sure that the moved theme is still displayed in the list
            6. TEST: make sure that the name of the theme is displayed correctly
            7. TEST: make sure that when the theme is selected, it works as if it was in the standard location
            David Mudrak made changes -
            Comment [ INSTRUCTIONS FOR TESTING (difficulty: moderate, requires access to the server filesystem)

            Note that this issue can be effectively tested together with MDL-26955

            1. Create a folder called 'morethemes' in moodledata directory and set permissions so that the web server can at least read it
            2. Put the following into your config.php: $CFG->themedir = $CFG->dataroot.'/morethemes';
            3. Move a theme folder from $CFG->dirroot/theme/ into the morethemes folders
            4. Go to the theme selector
            5. TEST: make sure that the moved theme is still displayed in the list
            6. TEST: make sure that the name of the theme is displayed correctly
            7. TEST: make sure that when the theme is selected, it works as if it was in the standard location ]
            Eloy Lafuente (stronk7) made changes -
            Labels ci pullweek-2011-18,
            Eloy Lafuente (stronk7) made changes -
            Labels ci pullweek-2011-18, ci pullweek-2011-18
            Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Aparup Banerjee made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester nebgor
            Aparup Banerjee made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            made changes -
            Status Tested [ 10006 ] Problem during testing [ 10007 ]
            Eloy Lafuente (stronk7) made changes -
            Status Problem during testing [ 10007 ] Integration review in progress [ 10004 ]
            Eloy Lafuente (stronk7) made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Eloy Lafuente (stronk7) made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Eloy Lafuente (stronk7) made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Fix Version/s 2.1 [ 10370 ]
            Resolution Fixed [ 1 ]
            Eloy Lafuente (stronk7) made changes -
            Labels ci pullweek-2011-18 pullweek-2011-18
            Eloy Lafuente (stronk7) made changes -
            Integration date 4/May/11

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: