Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27118

Text in a highlighted topic box is white on white in the Leatherbound theme.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.4
    • Component/s: Themes
    • Testing Instructions:
      Hide

      Switch to leatherbound theme and visit a topics course. Select a topic as 'current'. Labels and text in the 'current' topic should be legible.

      Show
      Switch to leatherbound theme and visit a topics course. Select a topic as 'current'. Labels and text in the 'current' topic should be legible.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When using the Leatherbound theme, highlighting a course topic will change the colour of any basic text (i.e. hyperlinks are unaffected) from black on white to white on white. The topic title, summary and labels are therefore unreadable in a highlighted topic.

      If the course is in weekly format, the section name (whether they be the dates or a custom section name) IS displayed correctly in a highlighted topic.

      I would guess this is happening because when the course is in topics format, the topic number needs to change to white to contrast against the orange bars either side of a highlighted topic.

        Gliffy Diagrams

          Activity

          Hide
          liamcline Liam Cline added a comment -

          Is it the course topic on the central frame, or the side nav-bar?
          Does this happen anywhere else? If it's just the course theme subset, one can just use the ::selection pseudo-element to hard-set the selection colour to orange.

          If that is the case, I can make a patch

          Show
          liamcline Liam Cline added a comment - Is it the course topic on the central frame, or the side nav-bar? Does this happen anywhere else? If it's just the course theme subset, one can just use the ::selection pseudo-element to hard-set the selection colour to orange. If that is the case, I can make a patch
          Hide
          liamcline Liam Cline added a comment -

          I overrode the browser default selection colour (white in the problem user's instance) w/ the orange standard in the theme, and white text. Hopefully this will fit with the theme.

          Show
          liamcline Liam Cline added a comment - I overrode the browser default selection colour (white in the problem user's instance) w/ the orange standard in the theme, and white text. Hopefully this will fit with the theme.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi John, looks good to me.
          2 minor things:

          1. The style is indented by only 2 space - should be 4
          2. There is a space after the }
            Feel free to submit for integration when you are ready.
          Show
          samhemelryk Sam Hemelryk added a comment - Hi John, looks good to me. 2 minor things: The style is indented by only 2 space - should be 4 There is a space after the } Feel free to submit for integration when you are ready.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks John this has been integrated now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks John this has been integrated now.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          tested as instructed, works here. Passing, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - tested as instructed, works here. Passing, thanks!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          This is now upstream, yay! Many thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - This is now upstream, yay! Many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Aug/11