Moodle
  1. Moodle
  2. MDL-27138

Embedded resources require specific div ids

    Details

    • Affected Branches:
      MOODLE_20_STABLE

      Description

      To replicate this issue, use a moodle 2 theme that does not use the ids #page-header and #page-footer (magazine for instance). Then, embed a resource URL. The resource object box is not given a height, and is therefore not displayed. This issue also occurs with the view/agree to site policy.

      It could be fixed by making sure every theme has #page-header and #page-footer divs. Or, it could be fixed in some other manner that does not rely on theme divs.

      If it is decided to fix via adding in #page-header and #page-footer, please re-assign to me.

        Gliffy Diagrams

          Activity

          Hide
          Petr Skoda added a comment -

          yes, these should be fixed - every theme has to use the same page structure.

          Show
          Petr Skoda added a comment - yes, these should be fixed - every theme has to use the same page structure.
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this.

          If you could add some screenshots, that would help.

          I've put it on our backlog and we'll try to get to it as soon as we can.

          In the meantime feel free to help us work on this issue.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. If you could add some screenshots, that would help. I've put it on our backlog and we'll try to get to it as soon as we can. In the meantime feel free to help us work on this issue.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          Eloy Lafuente (stronk7) added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: