Moodle
  1. Moodle
  2. MDL-27140

Problem with hidden sections on weeks course format

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: 2.0.2
        • Fix Version/s: 2.0.4
        • Component/s: Course
        • Environment:
          Linux; PHP 5.2;

          Description

          When some sections are hidden, moodle totally confuses the weeknumbers and when hidding some sections, some labels get scrambled.

            Gliffy Diagrams

            1. HTML File
              patch
              0.5 kB
              Nikhil Gupta
            1. moodle_section_incorrect.png
              61 kB
            2. moodle_section_incorrect2.png
              47 kB

              Issue Links

              will help resolve

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-25852 Weekly Format File Uploads show wrong header date

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Robin de Vries added a comment - - edited

                The situation is worse than I though, see new screenshot.

                Excuse me: I've uploaded one picture double, can somebody delete it for me?

                Show
                Robin de Vries added a comment - - edited The situation is worse than I though, see new screenshot. Excuse me: I've uploaded one picture double, can somebody delete it for me?
                Hide
                Permalink
                Nikhil Gupta added a comment -

                Hi Robin,
                Yes you are right,it seems to be very confusing,if the section is hidden,then the weeknumbers are totally jumbled..i am trying to make a patch for it..

                thnx
                nikhil

                Show
                Nikhil Gupta added a comment - Hi Robin, Yes you are right,it seems to be very confusing,if the section is hidden,then the weeknumbers are totally jumbled..i am trying to make a patch for it.. thnx nikhil
                Hide
                Permalink
                Robin de Vries added a comment -

                I think there is a relationship with MDL-25852

                Show
                Robin de Vries added a comment - I think there is a relationship with MDL-25852
                Hide
                Permalink
                Nikhil Gupta added a comment -

                Hello,
                I have fixed the bug and prepared patch file for it,i am attaching it.

                Thnx
                Nikhil

                Show
                Nikhil Gupta added a comment - Hello, I have fixed the bug and prepared patch file for it,i am attaching it. Thnx Nikhil
                Hide
                Permalink
                Robin de Vries added a comment -

                Hi,

                Patch worked fine for me

                Thanks,
                Robin

                Show
                Robin de Vries added a comment - Hi, Patch worked fine for me Thanks, Robin
                Hide
                Permalink
                Robin de Vries added a comment -

                Can someone apply the patch on the current moodle versions?

                Show
                Robin de Vries added a comment - Can someone apply the patch on the current moodle versions?
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                The change seems correct, thanks!

                I've transformed the patch into (better) git branches, and I'm sending this for integration tomorrow. If everything goes well, it will be available in next weekly build next Thursday.

                Thanks Nikhil Gupta and Robin de Vries!

                Show
                Eloy Lafuente (stronk7) added a comment - The change seems correct, thanks! I've transformed the patch into (better) git branches, and I'm sending this for integration tomorrow. If everything goes well, it will be available in next weekly build next Thursday. Thanks Nikhil Gupta and Robin de Vries!
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Thanks guys this has been integrated now.

                I also tested during integration so this will pass testing immediately as well

                Cheers
                Sam

                Show
                Sam Hemelryk added a comment - Thanks guys this has been integrated now. I also tested during integration so this will pass testing immediately as well Cheers Sam
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Passed

                Show
                Sam Hemelryk added a comment - Passed
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Closing, because this has been sent upstream some minutes ago.

                Many thanks for your collaboration!

                Show
                Eloy Lafuente (stronk7) added a comment - Closing, because this has been sent upstream some minutes ago. Many thanks for your collaboration!

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: