[MDL-27193] Eliminate DB queries in mod/glossary/settings.php - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_20_STABLE, MOODLE_311_STABLE, MOODLE_33_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/andyjdavis/moodle
Pull Master Branch:
~~MDL-27193~~_glossaryDB
Pull Master Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-27193_glossaryDB
Testing Instructions:
Hide

Visit /admin/settings.php?section=modsettingglossary You should see 7 formats under "Display formats setup" listed in alphabetical order.

Verify clicking on one of the format visibility icons should cause the eye to toggle open/closed.

Verify clicking one of the format settings icons should take you to a page of settings for that specific glossary format.

Verify clicking on 'site administration' and searching for something related to glossary display formats (eg dictionary) results in the respective display format being returned in the search results.
Show
Visit /admin/settings.php?section=modsettingglossary You should see 7 formats under "Display formats setup" listed in alphabetical order. Verify clicking on one of the format visibility icons should cause the eye to toggle open/closed. Verify clicking one of the format settings icons should take you to a page of settings for that specific glossary format. Verify clicking on 'site administration' and searching for something related to glossary display formats (eg dictionary) results in the respective display format being returned in the search results.

This is an extension of ~~MDL-27123~~.

Someone needs to do a search for $DB in all settings.php files, and all files in admin/settings, and get rid of them all.

The normal trick for doing this is as in this change: https://github.com/timhunt/moodle/commit/7351b54e86a408354e66f885c1561b8cb904032b. Use the lazy-loading facility provided by admin_setting_configselect so that the database query is only done when necessary.

Participants:: Andrew Davis, Andrew Lyons, Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Michael de Raadt, Petr Skoda, Tim Hunt

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Estimated:

Remaining:

Logged:

2h 20m