Moodle
  1. Moodle
  2. MDL-27196

Untranslatable string in Workshop module

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.4
    • Component/s: Workshop
    • Labels:
      None
    • Rank:
      16828

      Description

      I've found an untranslatable string in the assessment form of the workshop module.

      Have searched a bit and I'm pretty sure that the wrong line is in

      form/numerrors/assessment_form.php:74: $mform->addElement('radio', 'grade_idx' . $i, 'Your assessment', $fields->

      {'grade0__idx_'.$i}

      , 0); // todo localize

      which clearly is marked as "todo localize"

        Activity

        Hide
        David Mudrak added a comment -

        Ooops, thanks for the report!

        Show
        David Mudrak added a comment - Ooops, thanks for the report!
        Hide
        David Mudrak added a comment -

        The submitted branch fixes the reported hardcoded string as well as some others spotted during a general code review.

        Show
        David Mudrak added a comment - The submitted branch fixes the reported hardcoded string as well as some others spotted during a general code review.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, assuming that other strings like 'debug::indent::next square should be from group id ' were left untranslated by the developer and the target for this was, mainly 'Your assessment'.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, assuming that other strings like 'debug::indent::next square should be from group id ' were left untranslated by the developer and the target for this was, mainly 'Your assessment'. Ciao
        Hide
        David Mudrak added a comment -

        Correct, the debugging strings are left in English intentionally. Thanks for the prompt integration!

        Show
        David Mudrak added a comment - Correct, the debugging strings are left in English intentionally. Thanks for the prompt integration!
        Hide
        Sam Hemelryk added a comment -

        PASS

        Show
        Sam Hemelryk added a comment - PASS
        Hide
        Eloy Lafuente (stronk7) added a comment -

        All git & cvs servers have been updated with these cool changes, so closing, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - All git & cvs servers have been updated with these cool changes, so closing, many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: