Moodle
  1. Moodle
  2. MDL-27200

missing curly braces in hexanotallowed in qtype_calculated and other places

    Details

      Description

      $a->value is not wrapped between a set of curly braces in $string['hexanotallowed'] in qtype_calculated

        Gliffy Diagrams

          Activity

          Hide
          Tim Hunt added a comment -

          I grepped for

          ^\$string[.*[^{]\$a\b

          and found some other occurrences to fix.

          Show
          Tim Hunt added a comment - I grepped for ^\$string[.* [^{] \$a\b and found some other occurrences to fix.
          Hide
          Aparup Banerjee added a comment -

          peer-review: looks fine to me. those LTI ones were weird Aye.

          Show
          Aparup Banerjee added a comment - peer-review: looks fine to me. those LTI ones were weird Aye.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Oh no Apu, I think I may be rubbing off on you aye!

          Show
          Sam Hemelryk added a comment - Oh no Apu, I think I may be rubbing off on you aye !
          Hide
          Sam Hemelryk added a comment -

          Good spotting thanks Tim, changes look perfect.
          I'll integrate this during the next integration cycle starting either later today or tomorrow hopefully.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Good spotting thanks Tim, changes look perfect. I'll integrate this during the next integration cycle starting either later today or tomorrow hopefully. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Integrated now

          Show
          Sam Hemelryk added a comment - Integrated now
          Hide
          Petr Skoda added a comment -

          tested by grepping for [^\{]\$a[^a-z] - that would reveal problems in multiline strings and found one in string $string['welcomep20'] in /install/lang/he/install.php, should I report it somewhere?

          Show
          Petr Skoda added a comment - tested by grepping for [^\{] \$a [^a-z] - that would reveal problems in multiline strings and found one in string $string ['welcomep20'] in /install/lang/he/install.php, should I report it somewhere?
          Hide
          Petr Skoda added a comment -

          David is going to deal with the he lang pack somehow, test passed

          Show
          Petr Skoda added a comment - David is going to deal with the he lang pack somehow, test passed
          Hide
          David Mudrak added a comment -

          The fix of the typo in the language string submitted to the Hebrew maintainers in AMOS as a contribution #2466

          Show
          David Mudrak added a comment - The fix of the typo in the language string submitted to the Hebrew maintainers in AMOS as a contribution #2466
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: