Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0, 2.0.1, 2.0.2
-
Component/s: External Tool (IMS-LTI), Gradebook, Questions
-
Labels:None
-
Testing Instructions:
-
Difficulty:Easy
-
Affected Branches:MOODLE_20_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
$a->value is not wrapped between a set of curly braces in $string['hexanotallowed'] in qtype_calculated
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
peer-review: looks fine to me. those LTI ones were weird Aye.
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
Oh no Apu, I think I may be rubbing off on you aye!
Good spotting thanks Tim, changes look perfect.
I'll integrate this during the next integration cycle starting either later today or tomorrow hopefully.
Cheers
Sam
Integrated now
tested by grepping for [^\{]\$a[^a-z] - that would reveal problems in multiline strings and found one in string $string['welcomep20'] in /install/lang/he/install.php, should I report it somewhere?
David is going to deal with the he lang pack somehow, test passed
The fix of the typo in the language string submitted to the Hebrew maintainers in AMOS as a contribution #2466
The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!
Closing, ciao
I grepped for
^\$string[.*[^{]\$a\b
and found some other occurrences to fix.