Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27228

Label edit eye edit button show/hide not working

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: JavaScript
    • Labels:

      Description

      Create a label and set it to 'hide'.

      When returning to the course the 'eye' icon is not displayed in grey i.e as if the label is visible.
      Using the button to toggle display works as expected.

      This issue appears similar to (fixed) MDL-22653.

      Patch exists, will post github link shortly.

        Gliffy Diagrams

          Activity

          Hide
          tlevi Tony Levi added a comment -

          https://github.com/tlevi/moodle/tree/mdl27228

          I hope this is the 'correct' patch, maybe it is not and someone else must investigate this.

          Show
          tlevi Tony Levi added a comment - https://github.com/tlevi/moodle/tree/mdl27228 I hope this is the 'correct' patch, maybe it is not and someone else must investigate this.
          Hide
          tlevi Tony Levi added a comment -

          Any reason this cannot be applied? Not sure if 2.1 is affected too...

          Show
          tlevi Tony Levi added a comment - Any reason this cannot be applied? Not sure if 2.1 is affected too...
          Hide
          skodak Petr Skoda added a comment -

          To integrators: please cherry pick to all 2.x branches

          Thanks for the report and patch!

          Show
          skodak Petr Skoda added a comment - To integrators: please cherry pick to all 2.x branches Thanks for the report and patch!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks (backported to 20 and 21 stable)

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks (backported to 20 and 21 stable)
          Hide
          andyjdavis Andrew Davis added a comment -

          Seems to be working as expected now.

          Show
          andyjdavis Andrew Davis added a comment - Seems to be working as expected now.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Oct/11