Moodle
  1. Moodle
  2. MDL-27246

Unable to check out strings into the language customization tool

    Details

    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide

      1. Go to Site administration > Language > Language customization
      2. TEST: make sure you are able to check out strings into the translator without the reported error (would be nice to test at PostgreSQL where this was reported)

      Show
      1. Go to Site administration > Language > Language customization 2. TEST: make sure you are able to check out strings into the translator without the reported error (would be nice to test at PostgreSQL where this was reported)
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27246-cutomlang-version
    • Rank:
      17323

      Description

      Since commit bb8b29 the version.php started to use decimal number for version. This leads to problems in the customlang report:

      Debug info: ERROR: invalid input syntax for integer: "2011033002.02"
      INSERT INTO mdl_report_customlang_components (name,version) VALUES($1,$2) RETURNING id
      [array (
      'name' => 'core',
      'version' => '2011033002.02',
      )]
      Stack trace:

      • line 394 of /lib/dml/moodle_database.php: dml_write_exception thrown
      • line 232 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
      • line 781 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
      • line 833 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->insert_record_raw()
      • line 101 of /admin/report/customlang/locallib.php: call to pgsql_native_moodle_database->insert_record()
      • line 48 of /admin/report/customlang/index.php: call to report_customlang_utils::checkout()

        Issue Links

          Activity

          David Mudrak created issue -
          David Mudrak made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 69382 ] MDL Full Workflow [ 76693 ]
          David Mudrak made changes -
          Link This issue blocks MDL-27293 [ MDL-27293 ]
          David Mudrak made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Pull Master Diff URL https://github.com/mudrd8mz/moodle/compare/master...MDL-27246-cutomlang-version
          Pull Master Branch MDL-27246-cutomlang-version
          Pull 2.0 Diff URL https://github.com/mudrd8mz/moodle/compare/MOODLE_20_STABLE...MDL-27246-cutomlang-version_20_STABLE
          Pull 2.0 Branch MDL-27246-cutomlang-version_20_STABLE
          Pull from Repository git://github.com/mudrd8mz/moodle.git
          David Mudrak made changes -
          Fix Version/s 2.1 [ 10370 ]
          David Mudrak made changes -
          Status Waiting for peer review [ 10012 ] Waiting for review [ 10010 ]
          David Mudrak made changes -
          Testing Instructions 1. Go to Site administration > Language > Language customization
          2. TEST: make sure you are able to check out strings into the translator without the reported error (would be nice to test at PostgreSQL where this was reported)
          David Mudrak made changes -
          Comment [ INSTRUCTIONS FOR TESTING (difficulty: trivial)

          1. Go to Site administration > Language > Language customization
          2. TEST: make sure you are able to check out strings into the translator without the reported error (would be nice to test at PostgreSQL where this was reported) ]
          Eloy Lafuente (stronk7) made changes -
          Labels ci pullweek-2011-18,
          Eloy Lafuente (stronk7) made changes -
          Labels ci pullweek-2011-18, ci pullweek-2011-18
          Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Aparup Banerjee made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester nebgor
          Aparup Banerjee made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Fix Version/s 2.1 [ 10370 ]
          Resolution Fixed [ 1 ]
          Eloy Lafuente (stronk7) made changes -
          Labels ci pullweek-2011-18 pullweek-2011-18
          Eloy Lafuente (stronk7) made changes -
          Integration date 4/May/11

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: