Possible patch at https://github.com/arborrow/moodle/compare/MOODLE_20_STABLE...MDL-27278

This might be related to the fact that originally admins could not go to "My moodle" page for performance reasons because it would process all site courses. Now we have enrolments, so technically it could be supported now, we would have to make 100% sure this would not be causing performance problems.

However nobody should be using admin accounts for normal work in Moodle, it should be used only for server configuration and administration...

Regardless, my +1 to make the admin setting work the same as normal users.

OK, thanks for moving this over Anthony.

If I'm understanding this correctly the setting referred to is for users who are non-admins. I tested with a non-admin account and couldn't find where to set my preference (if allowed).

Also, we seem to have lost the ability for admins to force (i.e. restrict to) non-admins to the "my Moodle" page. I'm not a fan of that approach but I've seen it used on many sites - probably an unecessary migration headache....

Site admin accounts being used for "normal work". Agreed, they shouldn't be. So.... perhaps controversially... shouldn't that acct only have site config permissions? Should I open a new issue or is that suggestion fatally flawed in a way I can't see?

Ray,

The setting should be, at least IMHO, for all users as it is a user preference. Even site admins have preferences and I expect them to work. I also think that it is possible to force users to the my page unless I am missing something. The option to set the defaulthomepage to My Moodle should still work but I have not specifically tested it. If it is not working, let me know as that may be a separate bug (I am deliberately trying to keep this issue simple and straightforward). Regardless of how the site admin account is or should be used - respecting settings and having consistent behavior to other users I think is important. I'm not sure that your suggestion is flawed, I just don't understand the rationale behind it.

Peace - Anthony

Hi guys,

Indeed this sort of user preference should be aplicable to all users admin included.
I've created a patch for this now that tidies up the bit of code in question and is now up for peer-review.

Cheers
Sam

Putting this up for integration this week.

Had a quick look. The changes looks sensible enough. Mostly looks like a bit of a reshuffle to remove repeated has_capability() calls which probably should have been done as part of a separate issue. tisk tisk

integrated and ready for testing.

Thanks for the sanity check Andrew.

ps: main change is right before redirect($CFG->wwwroot .'/my/');

This is working great.

Test passed.

Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

Closing, ciao

Line 61 of index.php is a killer as it changes an acceptable behaviour for some sites eg default home page is "my" but users can still navigate to site home (via navigation block) if they choose.

The changes now make the "Site Home" link (in navigation block) redundant as it always redirects to "My" (for those without moodle/site:config capability).

Is there any work-around for this scenario?

Hi Shane,

I've just been looking into this, I don't think this change has had that effect.
To be sure I reset my master branch back to bdfb2b7 (the commit before my changes) and found that logged in as a student if default home page was /my/ I would always be redirected to /my/ if I arrived at / unless an optional param 'redirect=0' is provided at the same time. The navigation does this (the home page link on the navigation should have ?redirect=0).

The redirection issue did ring a bell though. I had a quick search and found MDL-23024 which is about adding back the mymoodleredirect setting so that we use that [consistently] rather than the ugly somewhat hacky redirect get param.
Adding this setting back, perhaps as forcehomepage would allow us to force the redirect only if that setting were true.

I'm thinking that the solution you are looking for is likely that, does that sound about right?

Cheers
Sam

Hi Sam,

The problem is this line:

} else if ($CFG->defaulthomepage == HOMEPAGE_MY && (optional_param('redirect', true, PARAM_BOOL) || !$hassiteconfig)) {

You are correct about the previous behaviour. The problem now is that "?redirect=0" no longer works for the average user as "!$hassiteconfig" evaluates to true forcing the redirect to /my

Cheers,
Shane.