Moodle

A wiki string wording

Details

  • Testing Instructions:
    Hide

    Run the following command on each patched branch and make sure a single line is returned:

    cat mod/wiki/lang/en/wiki.php | grep "\['navigationto_help'\] = 'Links to other pages"

    note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "navigationto_help" string and make sure its value is "Links to other pages" string.

    Show
    Run the following command on each patched branch and make sure a single line is returned: cat mod/wiki/lang/en/wiki.php | grep "\['navigationto_help'\] = 'Links to other pages" note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "navigationto_help" string and make sure its value is "Links to other pages" string.
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    m_MDL-27285_fixing_grammar_on_wiki_links_page
  • Pull Master Diff URL:

Description

$string['navigationto_help'] in the Wiki module reads "The links that included in this page". It seems to be unclear to me, if not a grammar typo.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Helen Foster added a comment -

Thanks David, adding to my list of lang string editing issues for use when practising Git stuff

Show
Helen Foster added a comment - Thanks David, adding to my list of lang string editing issues for use when practising Git stuff
Hide
Permalink
Helen Foster added a comment -

How about 'Links to other pages.'

Show
Helen Foster added a comment - How about 'Links to other pages.'
Hide
Permalink
Gerard Caulfield added a comment -

Hi Hellen

For now I'm just adding the word "are" as in:
"The links that are included in this page"

I do like your version but changing the entire phrase will probably mean it has to be re-translated in every language, doesn't it? I only speak English, so if that's not how it works please correct me and I'll change the patch to your phrasing.

Show
Gerard Caulfield added a comment - Hi Hellen For now I'm just adding the word "are" as in: "The links that are included in this page" I do like your version but changing the entire phrase will probably mean it has to be re-translated in every language, doesn't it? I only speak English, so if that's not how it works please correct me and I'll change the patch to your phrasing.
Hide
Permalink
David Mudrak added a comment -

Gerard, please use Helen's version. It does not change the meaning of the phrase so there is no need to re-translate it.

Show
David Mudrak added a comment - Gerard, please use Helen's version. It does not change the meaning of the phrase so there is no need to re-translate it.
Hide
Permalink
Gerard Caulfield added a comment -

Will do, thanks David.

Show
Gerard Caulfield added a comment - Will do, thanks David.
Hide
Permalink
Gerard Caulfield added a comment -

Ok, changed to Helen's version. Thanks for the quick feedback.

Show
Gerard Caulfield added a comment - Ok, changed to Helen's version. Thanks for the quick feedback.
Hide
Permalink
Adrian Greeve added a comment -

Looks great. Thanks Gerry.

Show
Adrian Greeve added a comment - Looks great. Thanks Gerry.
Hide
Permalink
Gerard Caulfield added a comment -

Thank you

Show
Gerard Caulfield added a comment - Thank you
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Gerry - this has been integrated now.

Show
Sam Hemelryk added a comment - Thanks Gerry - this has been integrated now.
Hide
Permalink
Andrew Davis added a comment -

The string is indeed updated. All the strings on the map -> links screen are a bit odd. "This page comes from" "this page goes to" anyhow...

Show
Andrew Davis added a comment - The string is indeed updated. All the strings on the map -> links screen are a bit odd. "This page comes from" "this page goes to" anyhow...
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

Closing as fixed, heading to zzzZZZzzz, niao

Show
Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: