Moodle
  1. Moodle
  2. MDL-27293

Maximum execution time exceeds when checking out the strings into the language customization tool

    Details

    • Testing Instructions:
      Hide

      0. Optional: to see the progress bar in action, clear the content of mdl_report_customlang table at your test server
      1. Go to Site administration > Language > Language customization
      2. Choose English as a language to customize
      3. Checkout strings into the translator
      4. TEST: make sure that a progress bar is displayed as strings are being loaded into the database
      5. TEST: make sure there is no execution timeout during the checkout

      Show
      0. Optional: to see the progress bar in action, clear the content of mdl_report_customlang table at your test server 1. Go to Site administration > Language > Language customization 2. Choose English as a language to customize 3. Checkout strings into the translator 4. TEST: make sure that a progress bar is displayed as strings are being loaded into the database 5. TEST: make sure there is no execution timeout during the checkout
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27293-customlang-timeout
    • Rank:
      17380

      Description

      As reported at http://moodle.org/mod/forum/discuss.php?d=163375 the checkout process may take a lot of time and the script is likely to run out of max execution time. The agreed solution is to increase the execution time and to display a progress bar so that the user is informed about the progress.

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          Please note that MDL-27246 must be merged before this.

          Show
          David Mudrak added a comment - Please note that MDL-27246 must be merged before this.
          Hide
          David Mudrak added a comment -

          Once MDL-27246 is merged, please pull this change too.

          The patch increases the maximum execution time to one hour and raises memory limit during the checkout of the strings.

          Show
          David Mudrak added a comment - Once MDL-27246 is merged, please pull this change too. The patch increases the maximum execution time to one hour and raises memory limit during the checkout of the strings.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks.

          Note: I've tested this already under 20_STABLE and master. I was not getting timeouts before the patches but raise_memory_limit() and set_time_limit() calls seem ok.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks. Note: I've tested this already under 20_STABLE and master. I was not getting timeouts before the patches but raise_memory_limit() and set_time_limit() calls seem ok.
          Hide
          Aparup Banerjee added a comment - - edited

          Strings checked out successfully into the translator! (couldn't replicate timeout problem before too)

          Show
          Aparup Banerjee added a comment - - edited Strings checked out successfully into the translator! (couldn't replicate timeout problem before too)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Closing as fixed. Many thanks!

          PS: I think we don't use to put the "master" fixfor version unless it's something going exclusively there.

          Show
          Eloy Lafuente (stronk7) added a comment - Closing as fixed. Many thanks! PS: I think we don't use to put the "master" fixfor version unless it's something going exclusively there.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: