Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27294

When enlarging text (Zooming in) text does not wrap and so disappears in Overlay and Fusion themes

    Details

    • Testing Instructions:
      Hide

      This fixes the fusion and overlay themes so that when you zoom in, scrollbars are available to see all of the text.

      To test, create a page resource (comprised of text) in a course. Navigate to that page resource and switch themes to overlay/fusion. Zoom in multiple times (with Firefox for example). The browser's scrollbars should now be viewable and can be use to see all text.

      Show
      This fixes the fusion and overlay themes so that when you zoom in, scrollbars are available to see all of the text. To test, create a page resource (comprised of text) in a course. Navigate to that page resource and switch themes to overlay/fusion. Zoom in multiple times (with Firefox for example). The browser's scrollbars should now be viewable and can be use to see all text.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When using Moodle in a classroom and displaying a Moodle page on a screen, teachers often 'Zoom in' to enlarge the text and so make it easier to read. However, with two of the standard Moodle 2 themes (Overlay and Fusion), zooming in causes the text to disappear. Consequently these two themes are unusable in classroom situations, and also unusable for anyone who needs to enlarge the size of text. I have confirmed this behavior in various browsers on both Windows and Mac. I have attached screen-shots to illustrate this problem.

      While investigating this bug, I observed the following three types of behavior when zooming in (i.e enlarging text):

      1) The worst behavior: overlay and fusion
      on zooming: text to the right of the screen disappears, a right-left scroll bar does not appear which renders the text invisible. See the 'fusion' and 'overlay' screen shots for an example of this behavior.

      2) Bad behavior, but just usable: base, brick, canvas, formal white, magazine, splash
      on zooming: text to the right of the screen disappears, but a right-left scroll bar appears which means the text can e seen but this solution is not practical in a classroom situation. See the 'Brick' screen shot for an example of this behavior.

      3) Good behavior: all other standard themes
      on zooming: text to the right is forced to wrap round by a fixed margin meaning text os always visible, there's no need to scroll left to right. See the 'Serenity' screen shot for an example of how things should be.

        Gliffy Diagrams

          Activity

          stuart Peter Ruthven-Stuart created issue -
          stuart Peter Ruthven-Stuart made changes -
          Field Original Value New Value
          Description When using Moodle in a classroom and displaying a Moodle page on a screen, I often 'Zoom in' to enlarge the text and so make it easier to read. However, with two of the standard Moodle 2 these (Overlay and Fusion), this causes the text to disappear. Consequently these two themes are unusable in classroom situations, and for anyone that needs to enlarge the size of text. I have confirmed these behavior in various browsers on both Windows and Mac. I have attached screen-shots to illustrate this problem.

          While investigating this bug, I observed the following three types of behavior when zooming in (i.e enlarging text):

          1) The worst behavior: overlay and fusion
          on zooming: text to the right of the screen disappears, a right-left scroll bar does not appear which renders the text invisible. See the 'fusion' and 'overlay' screen shots for an example of this behavior.


          2) Bad behavior, but just usable: base, brick, canvas, formal white, magazine, splash
          on zooming: text to the right of the screen disappears, but a right-left scroll bar appears which means the text can e seen but this solution is not practical in a classroom situation. See the 'Brick' screen shot for an example of this behavior.

          3) Good behavior: all other standard themes
          on zooming: text to the right is forced to wrap round by a fixed margin meaning text os always visible, there's no need to scroll left to right. See the 'Serenity' screen shot for an example of how things should be.
          When using Moodle in a classroom and displaying a Moodle page on a screen, teachers often 'Zoom in' to enlarge the text and so make it easier to read. However, with two of the standard Moodle 2 themes (Overlay and Fusion), zooming in causes the text to disappear. Consequently these two themes are unusable in classroom situations, and also unusable for anyone who needs to enlarge the size of text. I have confirmed this behavior in various browsers on both Windows and Mac. I have attached screen-shots to illustrate this problem.

          While investigating this bug, I observed the following three types of behavior when zooming in (i.e enlarging text):

          1) The worst behavior: overlay and fusion
          on zooming: text to the right of the screen disappears, a right-left scroll bar does not appear which renders the text invisible. See the 'fusion' and 'overlay' screen shots for an example of this behavior.


          2) Bad behavior, but just usable: base, brick, canvas, formal white, magazine, splash
          on zooming: text to the right of the screen disappears, but a right-left scroll bar appears which means the text can e seen but this solution is not practical in a classroom situation. See the 'Brick' screen shot for an example of this behavior.

          3) Good behavior: all other standard themes
          on zooming: text to the right is forced to wrap round by a fixed margin meaning text os always visible, there's no need to scroll left to right. See the 'Serenity' screen shot for an example of how things should be.
          dougiamas Martin Dougiamas made changes -
          Workflow MDL Workflow [ 69458 ] MDL Full Workflow [ 76449 ]
          epsd John Stabinger made changes -
          Assignee Patrick Malley [ ptrkmkl ] John Stabinger [ epsd ]
          epsd John Stabinger made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          epsd John Stabinger made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Pull Master Diff URL https://github.com/epsd/moodle/compare/master...MDL-27294
          Pull Master Branch MDL-27294
          Pull 2.0 Diff URL https://github.com/epsd/moodle/compare/MOODLE_20_STABLE...MDL-27294-MOODLE_20_STABLE
          Pull 2.0 Branch MDL-27294-MOODLE_20_STABLE
          Pull from Repository git://github.com/epsd/moodle.git
          Testing Instructions This fixes the fusion and overlay themes so that when you zoom in, scrollbars are available to see all of the text.

          To test, create a page resource (comprised of text) in a course. Navigate to that page resource and switch themes to overlay/fusion. Zoom in multiple times (with Firefox for example). The browser's scrollbars should now be viewable and can be use to see all text.
          Hide
          stuart Peter Ruthven-Stuart added a comment -

          Hello John Stabinger,

          Thank you for working on a solution for this issue.

          However, please note that your suggested solution for the fusion and overlay themes - to enable horizontal scrollbars - is not the best. i.e. if a teacher is wanting to display some text to students via a projector, she is not going to want to scroll form left to right. Ideally, the text should be made to wrap round so that there's no need to scroll from left to right. It would be good if this was possible. Thanks.

          Show
          stuart Peter Ruthven-Stuart added a comment - Hello John Stabinger, Thank you for working on a solution for this issue. However, please note that your suggested solution for the fusion and overlay themes - to enable horizontal scrollbars - is not the best. i.e. if a teacher is wanting to display some text to students via a projector, she is not going to want to scroll form left to right. Ideally, the text should be made to wrap round so that there's no need to scroll from left to right. It would be good if this was possible. Thanks.
          Hide
          epsd John Stabinger added a comment -

          I realize it is not exactly what you wanted, but it fixes the immediate issues in Overlay and Fusion.

          The other themes use a min-width on major components. That is why when you zoom, the text does not wrap. Getting rid of the min-widths (to allow text-wrap at any resolution) in the other themes causes other issues (display problems).

          Show
          epsd John Stabinger added a comment - I realize it is not exactly what you wanted, but it fixes the immediate issues in Overlay and Fusion. The other themes use a min-width on major components. That is why when you zoom, the text does not wrap. Getting rid of the min-widths (to allow text-wrap at any resolution) in the other themes causes other issues (display problems).
          Hide
          stuart Peter Ruthven-Stuart added a comment -

          OK, understood. Thanks for your quick response.

          It's a pity that the min-width setting makes half the version 2 themes tricky to use in classroom / lecture room settings.

          Show
          stuart Peter Ruthven-Stuart added a comment - OK, understood. Thanks for your quick response. It's a pity that the min-width setting makes half the version 2 themes tricky to use in classroom / lecture room settings.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks John looks good to me, submit for integration when you are ready.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks John looks good to me, submit for integration when you are ready.
          samhemelryk Sam Hemelryk made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Development in progress [ 3 ]
          epsd John Stabinger made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Fix Version/s 2.0.3 [ 10537 ]
          samhemelryk Sam Hemelryk made changes -
          Currently in integration Yes
          samhemelryk Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks John this has been integrated now.
          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks John this has been integrated now. Cheers Sam
          samhemelryk Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          stronk7 Eloy Lafuente (stronk7) made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester stronk7
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Looks perfect. Pass. Thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Looks perfect. Pass. Thanks!
          stronk7 Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          stuart Peter Ruthven-Stuart made changes -
          Labels appearance fusion overlay usability appearance fusion overlay things_that_worked_in_1.9_but_not_in_2 usability
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          This is now upstream, yay! Many thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - This is now upstream, yay! Many thanks!
          stronk7 Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Fix Version/s 2.0.4 [ 10652 ]
          Fix Version/s 2.0.3 [ 10537 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes
          Integration date 9/Jun/11
          Subversion JIRA

          Links Hierarchy

           Documentation

          Invalid license: EXPIRED

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Aug/11