Moodle
  1. Moodle
  2. MDL-27296

URL resource pointing towards .swf does not display standard swf icon

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.1
    • Fix Version/s: None
    • Component/s: Resource
    • Labels:
      None
    • Affected Branches:
      MOODLE_21_STABLE
    • Rank:
      16985

      Description

      Found in v.2011042000.00

      When #d=400x600 is appended to URL resource pointed at swf file, the swf icon is not displayed.
      See #2 here: http://tracker.moodle.org/browse/PULL-708
      See attached screenshot for 'Linked and Resized swf'

        Activity

        Hide
        Glenn Ansley added a comment -

        Hi Petr,
        I think I've tracked it down to the resourcelib_guess_url_mimetype() in lib/resourcelib.php but I just got here so that's not confirmed yet

        Show
        Glenn Ansley added a comment - Hi Petr, I think I've tracked it down to the resourcelib_guess_url_mimetype() in lib/resourcelib.php but I just got here so that's not confirmed yet
        Hide
        Glenn Ansley added a comment -

        Hi Petr,
        I was wrong about that last file but I believe I've tracked it down. I'm no regex guru but I found the supplied patch elsewhere in the codebase and it seemed to make sense when I deconstructed it. It also solved the problem... but someone may want to give it a close eye. If you decide there's a better way to do it, theres an identical expression in lib/resourcelib.php on line 203.

        patch is here: https://github.com/glennansley/moodle/commit/383f9f2e20cb46fb897d48f2b9f2df1564975f97

        Show
        Glenn Ansley added a comment - Hi Petr, I was wrong about that last file but I believe I've tracked it down. I'm no regex guru but I found the supplied patch elsewhere in the codebase and it seemed to make sense when I deconstructed it. It also solved the problem... but someone may want to give it a close eye. If you decide there's a better way to do it, theres an identical expression in lib/resourcelib.php on line 203. patch is here: https://github.com/glennansley/moodle/commit/383f9f2e20cb46fb897d48f2b9f2df1564975f97
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Michael de Raadt added a comment -

        I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        This is being done as part of a bulk annual clean-up of issues.

        If you still believe this is an issue in supported versions, please create a new issue.

        Show
        Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: