Moodle
  1. Moodle
  2. MDL-27304

User link in Wiki history takes directs people to the 'top course' profile page which is of course hiden to most users.

    Details

    • Testing Instructions:
      Hide

      1. Create a wiki.
      2. Make an edit.
      3. Login as a student.
      4. Make an edit.
      5. As a different student, view the page's history.
      6. Click on the teacher's name.
      7. Click on the student's name.

      Show
      1. Create a wiki. 2. Make an edit. 3. Login as a student. 4. Make an edit. 5. As a different student, view the page's history. 6. Click on the teacher's name. 7. Click on the student's name.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27304-master
    • Rank:
      16995

      Description

      Clicking on a User's name in the Wiki history takes me to:

      http://vle.c.fun.ac.jp/moodle/user/profile.php?id=2616

      if behaving like other activity modules (e.g. quiz) it should take me to:

      http://vle.c.fun.ac.jp/moodle/user/view.php?id=2616&course=315

      i.e. the course part of the URL is missing.

      When students click on the same user's name in the Wiki history they get taken to the same 'top course' URL and so this error "The details of this user are not available to you".

        Activity

        Hide
        Dan Poltawski added a comment -

        Looks good. You could've also used $PAGE->course->id I think.

        Please create branches and testing instructions for submitting for integration.

        Show
        Dan Poltawski added a comment - Looks good. You could've also used $PAGE->course->id I think. Please create branches and testing instructions for submitting for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some hours ago...

        the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks guys, this has been integrated now
        Hide
        Jason Fowler added a comment -

        All good in all three versions

        Show
        Jason Fowler added a comment - All good in all three versions
        Hide
        Eloy Lafuente (stronk7) added a comment -

        FCT (fixed, closing, thanks). Ciao

        "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
        ~ Benjamin Disraeli

        Show
        Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: