Moodle

Undocking a Block with Editing On Results in Undocked Block with No Editing Icons

Details

  • Testing Instructions:
    Hide

    Before testing, purge cache.

    Test 1:

    1. Dock navigation block.
    2. Turn editing on.
    3. Undock the block (with editing still on).
    4. Make sure the (now) undocked block have appropriate editing icons.

    Test 2:

    1. Dock navigation block.
    2. Turn editing on
    3. Turn editin off
    4. Undock the block.
    5. Make sure the (now) undocked block does not have editing icons.
    Show
    Before testing, purge cache. Test 1: Dock navigation block. Turn editing on. Undock the block (with editing still on). Make sure the (now) undocked block have appropriate editing icons. Test 2: Dock navigation block. Turn editing on Turn editin off Undock the block. Make sure the (now) undocked block does not have editing icons.
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-mdl-27309
  • Pull Master Diff URL:

Description

1. Dock any block.
2. Turn editing on.
3. Undock the block (with editing still on).

The now-undocked block does not have any editing icons even though editing is still on. To get the icons to appear, user must turn editing off and back on.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35409 Editing buttons on blocks don't show after docking/undocking blocks

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36085 Extra non-AJAX button when undocking a block with AJAX and editing mode enabled

  • Minor - Minor loss of function where workaround is possible
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Minh-Tam Nguyen added a comment -

Also on qa.moodle.net as at today.
Also Moodle 2.1.1 vanilla

Show
Minh-Tam Nguyen added a comment - Also on qa.moodle.net as at today. Also Moodle 2.1.1 vanilla
Hide
Permalink
Mark Nielsen added a comment -

Also these steps work:

  1. Turn editing on.
  2. Dock a block (edit icons still present).
  3. Undock the same block, edit icons are missing.

I think this might be a bug with the undocking JS.

Show
Mark Nielsen added a comment - Also these steps work: Turn editing on. Dock a block (edit icons still present). Undock the same block, edit icons are missing. I think this might be a bug with the undocking JS.
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting that. I was able to replicate the problem.

I've put that on the backlog.

In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.

Show
Michael de Raadt added a comment - Thanks for reporting that. I was able to replicate the problem. I've put that on the backlog. In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.
Hide
Permalink
Mary Evans added a comment -

Is there any chance someone could take a look at this to get it fixed before Moodle 2.3 gets rolled out?

Show
Mary Evans added a comment - Is there any chance someone could take a look at this to get it fixed before Moodle 2.3 gets rolled out?
Hide
Permalink
Rajesh Taneja added a comment -

Not increasing the version, as it gets increased on release.

Show
Rajesh Taneja added a comment - Not increasing the version, as it gets increased on release.
Hide
Permalink
Adrian Greeve added a comment -

[Y] Syntax
[-] Output
[Y] Whitespace
[-] Language
[-] Databases
[Y] Testing
[-] Security
[-] Documentation
[Y] Git
[Y] Sanity check

The code makes sense to me and the testing that I did worked. Everything looks good.

Thanks Raj.

Show
Adrian Greeve added a comment - [Y] Syntax [-] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check The code makes sense to me and the testing that I did worked. Everything looks good. Thanks Raj.
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Adrian.

Show
Rajesh Taneja added a comment - Thanks Adrian.
Hide
Permalink
Dan Poltawski added a comment -

Integrated, thanks Raj

Show
Dan Poltawski added a comment - Integrated, thanks Raj
Hide
Permalink
David Monllaó added a comment -

It passes. Tested in 22, 23 and master. I've created a linked issue (MDL-36085) with a minor issue

Show
David Monllaó added a comment - It passes. Tested in 22, 23 and master. I've created a linked issue ( MDL-36085 ) with a minor issue
Hide
Permalink
Aparup Banerjee added a comment -

Your issue has dug up some gold.
It works great i've been told.
Go forth, be brave, be bold.

yay! "All your thoughts are belong to everyone."

Thanks and ciao!

Show
Aparup Banerjee added a comment - Your issue has dug up some gold. It works great i've been told. Go forth, be brave, be bold. yay! "All your thoughts are belong to everyone." Thanks and ciao!

People

Vote (4)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: