Moodle
  1. Moodle
  2. MDL-27314

Not possible to delete or regrade selected quiz attempts in separate groups mode

    Details

    • Testing Instructions:
      Hide

      1. Create a course with two groups, with a teacher and student in each.
      2. Edit/override the teacher role, so it does not have 'access all groups'.
      3. Create a quiz set to separate groups mode, and add some questions.
      4. Attempt it as some students from each group.
      5. As teacher, verify that you can delete quiz attempts from your group (using the overview and/or responses report).
      6. Try to hack the system using firebug: Find the checkbox like <input type="checkbox" value="238" name="attemptid[]"> and edit the attempt id to point to the attempt of a student not in your group, then click the delete button. The attempt should not be deleted. (It is just silently skipped, there is no error message.)

      Note that the code is different in 2.0, so the fix is different there. This really needs to be tested separately in 2.0 and more recent branches.

      Show
      1. Create a course with two groups, with a teacher and student in each. 2. Edit/override the teacher role, so it does not have 'access all groups'. 3. Create a quiz set to separate groups mode, and add some questions. 4. Attempt it as some students from each group. 5. As teacher, verify that you can delete quiz attempts from your group (using the overview and/or responses report). 6. Try to hack the system using firebug: Find the checkbox like <input type="checkbox" value="238" name="attemptid[]"> and edit the attempt id to point to the attempt of a student not in your group, then click the delete button. The attempt should not be deleted. (It is just silently skipped, there is no error message.) Note that the code is different in 2.0, so the fix is different there. This really needs to be tested separately in 2.0 and more recent branches.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      17006

      Description

      I have a class of 20 students, all of whom who took a quiz once.

      One of these students attempts needs to be deleted. So in the Results window I select that attempt, and then click on the [Delete selected attempts] button. The page reloads, but the attempt is still there. I've turned on Debug message to developer, but get no error messages.

      I've indicated the priority of this issues as a 'Blocker'. I suppose it's not the end of the world, but as a feature that worked fine in 1.9, it seems to me to be something that should work in the newer and better version 2.

        Issue Links

          Activity

          Peter Ruthven-Stuart created issue -
          Peter Ruthven-Stuart made changes -
          Field Original Value New Value
          Labels things_that_worked_in_1.9_but_not_in_2 usability
          Peter Ruthven-Stuart made changes -
          Description I have a class of 20 students, all of whom who took a quiz once.

          One of these students attempts needs to be deleted. So in the Results window I select that attempt, and then click on the [Delete selected attempts] button. The page reloads, but the attempt is still there. I've turned on Debug message to developer, but get no error messages.

          This was possible in 1.9.
          I have a class of 20 students, all of whom who took a quiz once.

          One of these students attempts needs to be deleted. So in the Results window I select that attempt, and then click on the [Delete selected attempts] button. The page reloads, but the attempt is still there. I've turned on Debug message to developer, but get no error messages.

          I've indicated the priority of this issues as a 'Blocker'. I suppose it's not the end of the world, but as a feature that worked fine in 1.9, it seems to me to be something that should work in the newer and better version 2.
          Priority Minor [ 4 ] Blocker [ 1 ]
          Labels things_that_worked_in_1.9_but_not_in_2 usability quiz things_that_worked_in_1.9_but_not_in_2 usability
          Tim Hunt made changes -
          Priority Blocker [ 1 ] Major [ 3 ]
          Labels quiz things_that_worked_in_1.9_but_not_in_2 usability
          Tim Hunt made changes -
          Summary Not possible to delete a quiz attempt - no error message Not possible to delete or regrade selected quiz attempts in separate groups mode
          Fix Version/s STABLE backlog [ 10463 ]
          Priority Major [ 3 ] Critical [ 2 ]
          Labels triaged
          Tim Hunt made changes -
          Link This issue is duplicated by MDL-27315 [ MDL-27315 ]
          Peter Ruthven-Stuart made changes -
          Labels triaged things_that_worked_in_1.9_but_not_in_2 triaged
          Anthony Borrow made changes -
          Link This issue is duplicated by MDL-26640 [ MDL-26640 ]
          Tim Hunt made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/timhunt/moodle/compare/master...MDL-27314
          Pull Master Branch MDL-27314
          Pull 2.0 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_20_STABLE...MDL-27314_20
          Pull from Repository git://github.com/timhunt/moodle.git
          Pull 2.0 Branch MDL-27314_20
          Fix Version/s 2.0.7 [ 11451 ]
          Fix Version/s 2.1.4 [ 11452 ]
          Fix Version/s 2.2 [ 10656 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Testing Instructions 1. Create a course with two groups, with a teacher and student in each.
          2. Edit/override the teacher role, so it does not have 'access all groups'.
          3. Create a quiz set to separate groups mode, and add some questions.
          4. Attempt it as some students from each group.
          5. As teacher, verify that you can delete quiz attempts from your group (using the overview and/or responses report).
          6. Try to hack the system using firebug: Find the checkbox like <input type="checkbox" value="238" name="attemptid[]"> and edit the attempt id to point to the attempt of a student not in your group, then click the delete button. The attempt should not be deleted. (It is just silently skipped, there is no error message.)

          Note that the code is different in 2.0, so the fix is different there. This really needs to be tested separately in 2.0 and more recent branches.
          Pull 2.1 Branch MDL-27314_21
          Pull 2.1 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_21_STABLE...MDL-27314_21
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.2.1 [ 11456 ]
          Fix Version/s 2.2 [ 10656 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.2 [ 10656 ]
          Affects Version/s 2.1.3 [ 11251 ]
          Affects Version/s 2.3 [ 10657 ]
          Sam Hemelryk made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester samhemelryk
          Sam Hemelryk made changes -
          Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
          Tim Hunt made changes -
          Link This issue will be resolved by MDL-30660 [ MDL-30660 ]
          Tim Hunt made changes -
          Link This issue will help resolve MDL-29047 [ MDL-29047 ]
          Tim Hunt made changes -
          Eloy Lafuente (stronk7) made changes -
          Status Problem during testing [ 10007 ] Integration review in progress [ 10004 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Sam Hemelryk made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Sam Hemelryk made changes -
          Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
          Eloy Lafuente (stronk7) made changes -
          Link This issue testing discovered MDL-30677 [ MDL-30677 ]
          Eloy Lafuente (stronk7) made changes -
          Status Problem during testing [ 10007 ] Integration review in progress [ 10004 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester samhemelryk stronk7
          Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 09/Dec/11

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: