Moodle
  1. Moodle
  2. MDL-27367

Completion status block shouldn't ever be blank

    Details

    • Testing Instructions:
      Hide

      Reproduce problem:

      • All users (inc students) see warnings when completion not enabled, or criteria not being set for both Course Completion Status and Self Completion blocks
      • A user can still view a Course Completion Status block details page if completion was enabled for the course, but was then turned off site wide (accessible via the block and clicking the "More Details" link).
      • If viewing the Course Completion Status block details page for a user not in a graded role in the course, shows the "You are not enroled as a student in this course" error message even for other users.

      Reproduce fix:

      • Only users with the course:edit capability should see warnings about completion not being enabled, or criteria not being set for both Course Completion Status and Self Completion blocks
      • If course completion is enabled for a course, but disabled sitewide show an error when viewing a Course Completion Status block details page
      • If viewing the Course Completion Status block details page for another user not in a graded role in the course, show the "User is not enroled as a student in this course" error message rather than "You are not enroled as a student in this course".
      • Show message in the Self Completion block if the users is already complete in the course, or has already self completed themselves.
      Show
      Reproduce problem: All users (inc students) see warnings when completion not enabled, or criteria not being set for both Course Completion Status and Self Completion blocks A user can still view a Course Completion Status block details page if completion was enabled for the course, but was then turned off site wide (accessible via the block and clicking the "More Details" link). If viewing the Course Completion Status block details page for a user not in a graded role in the course, shows the "You are not enroled as a student in this course" error message even for other users. Reproduce fix: Only users with the course:edit capability should see warnings about completion not being enabled, or criteria not being set for both Course Completion Status and Self Completion blocks If course completion is enabled for a course, but disabled sitewide show an error when viewing a Course Completion Status block details page If viewing the Course Completion Status block details page for another user not in a graded role in the course, show the "User is not enroled as a student in this course" error message rather than "You are not enroled as a student in this course". Show message in the Self Completion block if the users is already complete in the course, or has already self completed themselves.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull Master Branch:
      MDL-27367-HEAD
    • Rank (Obsolete):
      15782

      Description

      If you add the completionstatus block to a course but fail to set a completion type in the Completion Tracking Settings then the block simply returns empty content and is not displayed.

      This is confusing and unhelpful. I can't think of any reason why it shouldn't say (perhaps just to those with relevant capabilities) - "You need to set a type in the Completion Tracking Settings".

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Linking to issue used in commits.

          Show
          Sam Hemelryk added a comment - Linking to issue used in commits.
          Hide
          Sam Hemelryk added a comment -

          Thanks Aaron, this has been integrated now.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Aaron, this has been integrated now. Cheers Sam
          Hide
          Helen Foster added a comment -

          Had problems testing a couple of the points, perhaps because I didn't understand the instructions correctly Hope you can help me out Aaron...

          • Only users with the course:edit capability should see warnings about completion not being enabled, or criteria not being set for both Course Completion Status and Self Completion blocks - Test passed
          • If course completion is enabled for a course, but disabled sitewide show an error when viewing a Course Completion Status block details page - No more details link displayed if completion tracking is disabled site-wide
          • If viewing the Course Completion Status block details page for another user not in a graded role in the course, show the "User is not enroled as a student in this course" error message rather than "You are not enroled as a student in this course". - No more details link when viewing the course completion status block as a manager
          • Show message in the Self Completion block if the users is already complete in the course, or has already self completed themselves. - Test passed
          Show
          Helen Foster added a comment - Had problems testing a couple of the points, perhaps because I didn't understand the instructions correctly Hope you can help me out Aaron... Only users with the course:edit capability should see warnings about completion not being enabled, or criteria not being set for both Course Completion Status and Self Completion blocks - Test passed If course completion is enabled for a course, but disabled sitewide show an error when viewing a Course Completion Status block details page - No more details link displayed if completion tracking is disabled site-wide If viewing the Course Completion Status block details page for another user not in a graded role in the course, show the "User is not enroled as a student in this course" error message rather than "You are not enroled as a student in this course". - No more details link when viewing the course completion status block as a manager Show message in the Self Completion block if the users is already complete in the course, or has already self completed themselves. - Test passed
          Hide
          Helen Foster added a comment -

          Following a chat with Sam, I'm marking this issue as passed, as not seeing the more details link in points 2 and 4 is desired behaviour, and Sam has checked that if you manually go to the more details page, the correct error messages are shown.

          Show
          Helen Foster added a comment - Following a chat with Sam, I'm marking this issue as passed, as not seeing the more details link in points 2 and 4 is desired behaviour, and Sam has checked that if you manually go to the more details page, the correct error messages are shown.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Closing, because this has been sent upstream some minutes ago.

          Many thanks for your collaboration!

          Show
          Eloy Lafuente (stronk7) added a comment - Closing, because this has been sent upstream some minutes ago. Many thanks for your collaboration!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: