Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27368

course completion causes cron failure

    XMLWordPrintable

Details

    • MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • master_MDL-27368
    • Hide

      This can only really be tested by a dev.

      Before running upgrade:

      1. In Admin > Advanced settings 'Enable completion tracking' set to on
      2. Create a course, set Completion tracking to enabled
      3. Enrol a student to course
      4. In Course > Admin > Completion settings enable manual self compltion
      5. Add the self completion block in the course
      6. As student go to the course and mark it as complete with the block
      7. Create a junk record in the db with the same userid and course, e.g. INSERT INTO course_completions (userid, course) values (21, 2)

      Run the upgrade..

      1. Verify that the duplicate records are removed form db.
      Show
      This can only really be tested by a dev. Before running upgrade: In Admin > Advanced settings 'Enable completion tracking' set to on Create a course, set Completion tracking to enabled Enrol a student to course In Course > Admin > Completion settings enable manual self compltion Add the self completion block in the course As student go to the course and mark it as complete with the block Create a junk record in the db with the same userid and course, e.g. INSERT INTO course_completions (userid, course) values (21, 2) Run the upgrade.. Verify that the duplicate records are removed form db.

    Description

      It is also crashes cron with a 'more than one fetch' error.

      Attachments

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32119 Course Completion deleted column (and notify table)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28949 Duplicated course completion entries in database not handled correctly

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-32103 Make course completion instant for activity based completion criteria (single user completions only)

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29985 Cron backup fails due to Completion tracking/Activity Completion

          • Major - Major loss of function, incorrect output
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32102 restore creates invalid course completion records

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              danmarsden Dan Marsden
              sry_not4sale Aaron Barnes
              Andrew Davis Andrew Davis
              Dan Poltawski Dan Poltawski
              Frédéric Massart Frédéric Massart
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              27 Vote for this issue
              Watchers:
              21 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Jul/12