Moodle
  1. Moodle
  2. MDL-27381

Problems with Safari and the new "overwrite files" dialog

        Details

        • Database:
          Any
        • Testing Instructions:
          Hide

          To test, please use safari browse
          1. create forum post
          2. upload a file
          3. upload the same file with same name, a pop up dialog should appear on top

          Show
          To test, please use safari browse 1. create forum post 2. upload a file 3. upload the same file with same name, a pop up dialog should appear on top
        • Affected Branches:
          MOODLE_20_STABLE
        • Fixed Branches:
          MOODLE_20_STABLE
        • Pull from Repository:
          git@github.com:dongsheng/moodle.git
        • Pull Master Branch:
          s9_MDL-27381_overwrite_dialog_safari_master
        • Pull Master Diff URL:

          Description

          This is one followup of MDL-26388.

          In the testing phase it has been detected that the new "overwrite files" dialog, allowing to replace/rename/cancel is shown under any other dialog (file picker, add image...) when using the Safari browser (see attached image).

          It would be great to have this fixed ASAP for quick integration. Ciao

            Gliffy Diagrams

              Issue Links

              has a non-specific relationship to

              Improvement - An enhancement to an existing Moodle feature. MDL-26388 Handle duplicate files uploaded through filepicker

              • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
              • Closed

              Improvement - An enhancement to an existing Moodle feature. MDL-28019 Implement file management for HTML-related file areas

              • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Triaging and assigning straight to Dongsheng.

                Show
                Eloy Lafuente (stronk7) added a comment - Triaging and assigning straight to Dongsheng.
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Hi DS,

                This looks like its going to be as simple as setting a higher z-index on the overlay.
                If it is that simple could you please get a patch up and I'll integrate it today in time for the 2.0.3 release.

                Cheers
                Sam

                Show
                Sam Hemelryk added a comment - Hi DS, This looks like its going to be as simple as setting a higher z-index on the overlay. If it is that simple could you please get a patch up and I'll integrate it today in time for the 2.0.3 release. Cheers Sam
                Hide
                Permalink
                Dongsheng Cai added a comment -

                For undknown reason, safari completely ignore zindex property, I set zindex to 99999992, in safari, it uses zindex:11 no matter what I put in js

                Show
                Dongsheng Cai added a comment - For undknown reason, safari completely ignore zindex property, I set zindex to 99999992, in safari, it uses zindex:11 no matter what I put in js
                Hide
                Permalink
                Dongsheng Cai added a comment -

                Found the solution, seems YUI failed to make modal dialog really 'modal', I removed modal option, use zIndex property solve the problem

                Show
                Dongsheng Cai added a comment - Found the solution, seems YUI failed to make modal dialog really 'modal', I removed modal option, use zIndex property solve the problem
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Thanks DS this has been integrated now.

                Cheers
                Sam

                Show
                Sam Hemelryk added a comment - Thanks DS this has been integrated now. Cheers Sam
                Hide
                Permalink
                Aparup Banerjee added a comment -

                tested on safari for windows.
                the dialog appears fine for me in the proper Z order.

                (note: the file choosing dialog needed one more click as if focus was still elsewhere, but that may have been effects of my terminal client connecting to windows.)

                Show
                Aparup Banerjee added a comment - tested on safari for windows. the dialog appears fine for me in the proper Z order. (note: the file choosing dialog needed one more click as if focus was still elsewhere, but that may have been effects of my terminal client connecting to windows.)
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Yay, as a Safari-er, many thanks. Closing, ciao

                Show
                Eloy Lafuente (stronk7) added a comment - Yay, as a Safari-er, many thanks. Closing, ciao

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: