Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27399

Add all new the mobile ws functions to the built-in mobile service

    Details

    • Type: Task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: Web Services
    • Labels:
      None

      Description

      This is a place holder for tasks from the Moodle Mobile project for this sprint.

        Gliffy Diagrams

          Issue Links

            Activity

            moodle.com moodle.com created issue -
            moodle.com moodle.com made changes -
            Field Original Value New Value
            Fix Version/s Sprint to 2.1 [ 10650 ]
            moodle.com moodle.com made changes -
            Link This issue will help resolve MOBILE-2 [ MOBILE-2 ]
            moodle.com moodle.com made changes -
            Description This is a place holder for tasks that have been temporarily moved from the Moodle Mobile project for this sprint. This is a place holder for tasks from the Moodle Mobile project for this sprint.
            moodle.com moodle.com made changes -
            Link This issue will help resolve MOBILE-2 [ MOBILE-2 ]
            jerome Jérôme Mouneyrac made changes -
            Link This issue will help resolve MOBILE-2 [ MOBILE-2 ]
            Hide
            jerome Jérôme Mouneyrac added a comment - - edited

            List of functions currently used by the App:

            moodle_enrol_get_enrolled_users => description has been modified
            moodle_webservice_mobile_get_siteinfo => new function. TODO: return list of web services functions.
            moodle_enrol_get_courses_by_enrolled_users => TODO: switch to the newly moodle_enrol_get_users_courses that landed in core recently. It should work straight forward.
            Functions that will be required by Upload functionality:
            none yet

            Functions that will be required by Participant functionality:

            create private note => need to be created.
            send private message => need to be created.
            get users => already exist
            Total needed functions: 6
            Missing functions: 2

            Show
            jerome Jérôme Mouneyrac added a comment - - edited List of functions currently used by the App: moodle_enrol_get_enrolled_users => description has been modified moodle_webservice_mobile_get_siteinfo => new function. TODO: return list of web services functions. moodle_enrol_get_courses_by_enrolled_users => TODO: switch to the newly moodle_enrol_get_users_courses that landed in core recently. It should work straight forward. Functions that will be required by Upload functionality: none yet Functions that will be required by Participant functionality: create private note => need to be created. send private message => need to be created. get users => already exist Total needed functions: 6 Missing functions: 2
            jerome Jérôme Mouneyrac made changes -
            Priority Minor [ 4 ] Blocker [ 1 ]
            jerome Jérôme Mouneyrac made changes -
            Summary Create Web Service for Mobile Create Web Service for Mobile and add them all to the built-in mobile service
            jerome Jérôme Mouneyrac made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            jerome Jérôme Mouneyrac made changes -
            Summary Create Web Service for Mobile and add them all to the built-in mobile service Add all new the mobile ws functions to the built-in mobile service
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Sending for integration (trivial changes).
            Rebased/bumped the last version/no whitespaces

            Show
            jerome Jérôme Mouneyrac added a comment - Sending for integration (trivial changes). Rebased/bumped the last version/no whitespaces
            jerome Jérôme Mouneyrac made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            samhemelryk Sam Hemelryk made changes -
            Currently in integration Yes
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Jerome - this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Jerome - this has been integrated now.
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Hide
            nebgor Aparup Banerjee added a comment -

            This needs some testing instructions : guessing use the ws test client under development? or iphone?

            Show
            nebgor Aparup Banerjee added a comment - This needs some testing instructions : guessing use the ws test client under development? or iphone?
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Apu don't you have the iPhone app, or Andrew perhaps.
            Not too sure there is much we can do to test the functionality but for the time being we can test that turning it on&off several times doesn't cause any errors.

            I've already manually (separately) tested most of the web service functions that it uses so it should be fine.

            Show
            samhemelryk Sam Hemelryk added a comment - Apu don't you have the iPhone app, or Andrew perhaps. Not too sure there is much we can do to test the functionality but for the time being we can test that turning it on&off several times doesn't cause any errors. I've already manually (separately) tested most of the web service functions that it uses so it should be fine.
            Hide
            nebgor Aparup Banerjee added a comment -

            the iphone app i've (andrew too) got is hard linked to jerome.moodle.local

            testing with a generic ws test client..

            Show
            nebgor Aparup Banerjee added a comment - the iphone app i've (andrew too) got is hard linked to jerome.moodle.local testing with a generic ws test client..
            nebgor Aparup Banerjee made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester nebgor
            Hide
            nebgor Aparup Banerjee added a comment -

            the uploading of photos is working fine for me with iphone. :-D

            i dont' know if this is relevant (it may be), when manage tokens i get :

            Deprecated: Function split() is deprecated in /home/aparup/mcode/m20/mysql/moodle/webservice/lib.php on line 343
            Call Stack:
            0.0004 696584 1.

            {main}

            () /home/aparup/mcode/m20/mysql/moodle/admin/settings.php:0
            1.0047 90027240 2. admin_settingpage->output_html() /home/aparup/mcode/m20/mysql/moodle/admin/settings.php:126
            1.0047 90027728 3. admin_setting_managewebservicetokens->output_html() /home/aparup/mcode/m20/mysql/moodle/lib/adminlib.php:1343
            1.0095 90762696 4. webservice->get_missing_capabilities_by_users() /home/aparup/mcode/m20/mysql/moodle/lib/adminlib.php:7459
            1.0095 90763008 5. webservice->get_service_required_capabilities() /home/aparup/mcode/m20/mysql/moodle/webservice/lib.php:383

            Show
            nebgor Aparup Banerjee added a comment - the uploading of photos is working fine for me with iphone. :-D i dont' know if this is relevant (it may be), when manage tokens i get : Deprecated: Function split() is deprecated in /home/aparup/mcode/m20/mysql/moodle/webservice/lib.php on line 343 Call Stack: 0.0004 696584 1. {main} () /home/aparup/mcode/m20/mysql/moodle/admin/settings.php:0 1.0047 90027240 2. admin_settingpage->output_html() /home/aparup/mcode/m20/mysql/moodle/admin/settings.php:126 1.0047 90027728 3. admin_setting_managewebservicetokens->output_html() /home/aparup/mcode/m20/mysql/moodle/lib/adminlib.php:1343 1.0095 90762696 4. webservice->get_missing_capabilities_by_users() /home/aparup/mcode/m20/mysql/moodle/lib/adminlib.php:7459 1.0095 90763008 5. webservice->get_service_required_capabilities() /home/aparup/mcode/m20/mysql/moodle/webservice/lib.php:383
            Hide
            nebgor Aparup Banerjee added a comment -

            heres an error seen doing a unit test:
            SOAP protocol: moodle_user_get_users_by_id

            URL: http://aparup.moodle.local/m20/mysql/moodle/webservice/soap/simpleserver.php?wsusername=moodlews&wspassword=mood1eDEV%21
            Fatal error: SOAP-ERROR: Parsing WSDL: Couldn't find in 'http://aparup.moodle.local/m20/mysql/moodle/webservice/soap/simpleserver.php?wsusername=moodlews&wspassword=mood1eDEV%21&wsdl=1' in /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client/Common.php on line 51

            Call Stack:
            0.0008 727352 1.

            {main}

            () /home/aparup/mcode/m20/mysql/moodle/admin/webservice/testclient.php:0
            0.8835 78512496 2. webservice_soap_test_client->simpletest() /home/aparup/mcode/m20/mysql/moodle/admin/webservice/testclient.php:154
            0.8863 79163096 3. Zend_Soap_Client->__call() /home/aparup/mcode/m20/mysql/moodle/webservice/soap/locallib.php:155
            0.8863 79163096 4. Zend_Soap_Client->getSoapClient() /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client.php:1104
            0.8863 79163096 5. Zend_Soap_Client->_initSoapClientObject() /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client.php:1180
            0.8864 79165104 6. Zend_Soap_Client_Common->__construct() /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client.php:1024
            0.8864 79165184 7. SoapClient->SoapClient() /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client/Common.php:51

            Show
            nebgor Aparup Banerjee added a comment - heres an error seen doing a unit test: SOAP protocol: moodle_user_get_users_by_id URL: http://aparup.moodle.local/m20/mysql/moodle/webservice/soap/simpleserver.php?wsusername=moodlews&wspassword=mood1eDEV%21 Fatal error: SOAP-ERROR: Parsing WSDL: Couldn't find in 'http://aparup.moodle.local/m20/mysql/moodle/webservice/soap/simpleserver.php?wsusername=moodlews&wspassword=mood1eDEV%21&wsdl=1' in /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client/Common.php on line 51 Call Stack: 0.0008 727352 1. {main} () /home/aparup/mcode/m20/mysql/moodle/admin/webservice/testclient.php:0 0.8835 78512496 2. webservice_soap_test_client->simpletest() /home/aparup/mcode/m20/mysql/moodle/admin/webservice/testclient.php:154 0.8863 79163096 3. Zend_Soap_Client->__call() /home/aparup/mcode/m20/mysql/moodle/webservice/soap/locallib.php:155 0.8863 79163096 4. Zend_Soap_Client->getSoapClient() /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client.php:1104 0.8863 79163096 5. Zend_Soap_Client->_initSoapClientObject() /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client.php:1180 0.8864 79165104 6. Zend_Soap_Client_Common->__construct() /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client.php:1024 0.8864 79165184 7. SoapClient->SoapClient() /home/aparup/mcode/m20/mysql/moodle/lib/zend/Zend/Soap/Client/Common.php:51
            Hide
            nebgor Aparup Banerjee added a comment -

            stopping test. not sure how to proceed.

            Show
            nebgor Aparup Banerjee added a comment - stopping test. not sure how to proceed.
            nebgor Aparup Banerjee made changes -
            Status Testing in progress [ 10011 ] Waiting for testing [ 10005 ]
            Hide
            dongsheng Dongsheng Cai added a comment -

            re the split() issue, I will include the fix in MDL-27880.

            The soap client seems bug from lower level, it works well with token though, probably should file another bug

            Show
            dongsheng Dongsheng Cai added a comment - re the split() issue, I will include the fix in MDL-27880 . The soap client seems bug from lower level, it works well with token though, probably should file another bug
            dongsheng Dongsheng Cai made changes -
            Link This issue has been marked as being related by MDL-27880 [ MDL-27880 ]
            nebgor Aparup Banerjee made changes -
            Link This issue has been marked as being related by MDL-27881 [ MDL-27881 ]
            Hide
            nebgor Aparup Banerjee added a comment -

            the soap zend error has been reported as another bug : MDL-27881

            Show
            nebgor Aparup Banerjee added a comment - the soap zend error has been reported as another bug : MDL-27881
            Hide
            nebgor Aparup Banerjee added a comment -

            passing. issues seen will be handled by DS in other ongoing bug.

            Show
            nebgor Aparup Banerjee added a comment - passing. issues seen will be handled by DS in other ongoing bug.
            nebgor Aparup Banerjee made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            marking as passed, based on Aparup's previous comment, yay!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - marking as passed, based on Aparup's previous comment, yay!
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And now this is part of the best Moodle weeklies ever, thanks!

            Closing.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And now this is part of the best Moodle weeklies ever, thanks! Closing.
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Fix Version/s 2.1 [ 10370 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes
            Integration date 16/Jun/11
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s DEV Sprint 2.1 [ 10650 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Jul/11