Moodle

The excel export fails in some conditions.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.3, 2.1
  • Fix Version/s: 2.0.4
  • Component/s: Feedback
  • Testing Instructions:
    Hide

    create a feedback instance
    add one or more question (type: multichoice)
    go and submit some answers
    switch the moodle debug-level to "all"
    do an excel-export of the given feedback-answers
    open the excel-file in an text editor
    Now you can see some notice messages

    Show
    create a feedback instance add one or more question (type: multichoice) go and submit some answers switch the moodle debug-level to "all" do an excel-export of the given feedback-answers open the excel-file in an text editor Now you can see some notice messages
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

The excel export will fail in the following condition.

  • One question is a multichoice
  • debugging is set to all
    This is dueto two uninitialized properties in line 238, 239 and 246 in the file feedback/item/multichoice/lib.php.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andreas Grabs added a comment - - edited

Hi,

I have fixed this issue but I can not create a new pull-request. What I have to do that I can create a new one?
Here are the diff-urls
master: https://github.com/grabs/moodle/compare/master...MDL-27422
MOODLE_20_STABLE: https://github.com/grabs/moodle/compare/MOODLE_20_STABLE...MDL-27422-stable

Ciao
Andreas

Show
Andreas Grabs added a comment - - edited Hi, I have fixed this issue but I can not create a new pull-request. What I have to do that I can create a new one? Here are the diff-urls master: https://github.com/grabs/moodle/compare/master...MDL-27422 MOODLE_20_STABLE: https://github.com/grabs/moodle/compare/MOODLE_20_STABLE...MDL-27422-stable Ciao Andreas
Hide
Permalink
Andreas Grabs added a comment -

I'm hoping all is done correctly

Show
Andreas Grabs added a comment - I'm hoping all is done correctly
Hide
Permalink
Sam Hemelryk added a comment -

Hi Andreas,

I've just been looking at your patch now and am about to test it.
While I do that there were a couple of things about the patch I would like to ask you:

First looking at the history of the patch you commit your fix, you revert it, and then you commit it again. Is it OK with you if I just cherry-pick the last commit so that we don't get the initial commit+rejection (just helps keep our history clean).

Second I noticed that on your commit you name is Unknown and your email address is down as andy@.(none) Would you like to fix that up or would you like me to fix it up when I do the cherry-picking? If me then what would you like for those two fields?

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Andreas, I've just been looking at your patch now and am about to test it. While I do that there were a couple of things about the patch I would like to ask you: First looking at the history of the patch you commit your fix, you revert it, and then you commit it again. Is it OK with you if I just cherry-pick the last commit so that we don't get the initial commit+rejection (just helps keep our history clean). Second I noticed that on your commit you name is Unknown and your email address is down as andy@.(none) Would you like to fix that up or would you like me to fix it up when I do the cherry-picking? If me then what would you like for those two fields? Cheers Sam
Hide
Permalink
Andreas Grabs added a comment -

Hi Sam,

I know, I am very stupid on using git. I had/have still some problems in understanding git. First I did the coding and then I did see that I need a branch for that issue. After that I did see that I have to create two branches (stable and master) . I was not abled to manage these things. I was trying to reset my git repository but I could not do that.
But I am optimistic. There will be a time I can all these things .
Thank you for your patience.

Best regards
Andreas

Show
Andreas Grabs added a comment - Hi Sam, I know, I am very stupid on using git. I had/have still some problems in understanding git. First I did the coding and then I did see that I need a branch for that issue. After that I did see that I have to create two branches (stable and master) . I was not abled to manage these things. I was trying to reset my git repository but I could not do that. But I am optimistic. There will be a time I can all these things . Thank you for your patience. Best regards Andreas
Hide
Permalink
Sam Hemelryk added a comment -

Thats quite OK Andreas, this has been integrated now.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thats quite OK Andreas, this has been integrated now. Cheers Sam
Hide
Permalink
Helen Foster added a comment -

Tested in 2.0 and found feedback.xls file looking fine. Thanks Andreas

Show
Helen Foster added a comment - Tested in 2.0 and found feedback.xls file looking fine. Thanks Andreas
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Closing, because this has been sent upstream some minutes ago.

Many thanks for your collaboration!

Show
Eloy Lafuente (stronk7) added a comment - Closing, because this has been sent upstream some minutes ago. Many thanks for your collaboration!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: