Moodle
  1. Moodle
  2. MDL-27427

No option to Edit/Delete External blog entries

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1.5, 2.2.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Blog
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Register an external blog with a valid feed.
      Delete an entry from the imported feed.
      Trigger the admin/cli/cron.php to re-fetch the RSS feed.
      Check the blog entries to ensure the deleted entry hasn't been re-added.

      Show
      Register an external blog with a valid feed. Delete an entry from the imported feed. Trigger the admin/cli/cron.php to re-fetch the RSS feed. Check the blog entries to ensure the deleted entry hasn't been re-added.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-27427-master
    • Rank:
      17108

      Description

      Starting with Moodle 2.0, we have an option to import blog entries from external blog feeds. But there is no option to edit/delete these entries once they are imported.
      Its an obvious requirement to provide users with an option to edit or delete these entries.

        Activity

        Hide
        Mat Simon added a comment - - edited

        Also applies to the 2.1 branch (currently on 2.1.1).

        Even if you delete the external blog, the blog entries stay in Moodle and can't even be deleted by the initial moodle admin.
        Really would encourage addition of this feature!

        Show
        Mat Simon added a comment - - edited Also applies to the 2.1 branch (currently on 2.1.1). Even if you delete the external blog, the blog entries stay in Moodle and can't even be deleted by the initial moodle admin. Really would encourage addition of this feature!
        Hide
        MJ Warden added a comment -

        I second this feature/requirement. This really should be a control that a user has.

        Show
        MJ Warden added a comment - I second this feature/requirement. This really should be a control that a user has.
        Hide
        Mark Scacco added a comment -

        I vote for this as well

        Show
        Mark Scacco added a comment - I vote for this as well
        Hide
        Gavin Stokes added a comment -

        +1 for this.
        External blogs pulled into the online learning environment is a great feature.
        Need this one solved before we can really use it. Thanks!

        Show
        Gavin Stokes added a comment - +1 for this. External blogs pulled into the online learning environment is a great feature. Need this one solved before we can really use it. Thanks!
        Hide
        Jason Fowler added a comment -

        won't be adding this to old versions of Moodle, will implement it for 2.3dev as it's a new feature/improvement. Hopefully the code I create will allow for back porting though

        Show
        Jason Fowler added a comment - won't be adding this to old versions of Moodle, will implement it for 2.3dev as it's a new feature/improvement. Hopefully the code I create will allow for back porting though
        Hide
        Michael de Raadt added a comment -

        Carrying over to new sprint.

        Show
        Michael de Raadt added a comment - Carrying over to new sprint.
        Hide
        Jason Fowler added a comment -

        done for 2.3dev, will cherry pick backwards after peer review

        Show
        Jason Fowler added a comment - done for 2.3dev, will cherry pick backwards after peer review
        Hide
        Jason Fowler added a comment -

        I've only enabled deletion of external blog entries, rather than editing too, this is because the edited articles retain their link to the original (and unedited) article on the external website, and I feel allowing users to edit content that says it comes from an external, reputable, website may allow for the misrepresentation of information, and raises issues of trust and authenticity.

        Show
        Jason Fowler added a comment - I've only enabled deletion of external blog entries, rather than editing too, this is because the edited articles retain their link to the original (and unedited) article on the external website, and I feel allowing users to edit content that says it comes from an external, reputable, website may allow for the misrepresentation of information, and raises issues of trust and authenticity.
        Hide
        Michael de Raadt added a comment -

        Some comments about this fix.

        • Some comments are needed to distinguish the cases here.
        • The lines are longer than allowed and should be broken down.
        • Does the session key need to be passed with editing/deleting? Perhaps it should be.

        In the testing instructions, it would be good to test what happens after an external entry is collected then the feed is re-checked.

        In the docs, there is no mention of the potential for editing/deleting blog entries from an external source.

        http://docs.moodle.org/22/en/Using_Blogs#External_blogs

        There should be a note that says that entries, once imported into Moodle, can be deleted but not edited.

        Show
        Michael de Raadt added a comment - Some comments about this fix. Some comments are needed to distinguish the cases here. The lines are longer than allowed and should be broken down. Does the session key need to be passed with editing/deleting? Perhaps it should be. In the testing instructions, it would be good to test what happens after an external entry is collected then the feed is re-checked. In the docs, there is no mention of the potential for editing/deleting blog entries from an external source. http://docs.moodle.org/22/en/Using_Blogs#External_blogs There should be a note that says that entries, once imported into Moodle, can be deleted but not edited.
        Hide
        Aparup Banerjee added a comment -

        The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Aparup Banerjee added a comment - The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Just spoke to Jason about this - it seems this can be easily backported since its quite trivial.

        Also just a comment that I I think that the changing in the documentation before the fix has landed is not advisable as it leads our users to be confused (especially if this was going to be master only, that definitely should've stayed out of the 2.2 wiki).

        Show
        Dan Poltawski added a comment - Just spoke to Jason about this - it seems this can be easily backported since its quite trivial. Also just a comment that I I think that the changing in the documentation before the fix has landed is not advisable as it leads our users to be confused (especially if this was going to be master only, that definitely should've stayed out of the 2.2 wiki).
        Hide
        Dan Poltawski added a comment -

        Thanks, this has been integrated now to master, 22 and 21.

        Just a trivial note that the coding style rules have recently been refined to says that inline comments should have a space after the //. We also recommend a punctation mark closing the comment. The code checkers will warn about this. See http://docs.moodle.org/dev/Coding_style#Inline_comments

        Show
        Dan Poltawski added a comment - Thanks, this has been integrated now to master, 22 and 21. Just a trivial note that the coding style rules have recently been refined to says that inline comments should have a space after the // . We also recommend a punctation mark closing the comment. The code checkers will warn about this. See http://docs.moodle.org/dev/Coding_style#Inline_comments
        Hide
        Mat Simon added a comment -

        Thank you guys!

        Show
        Mat Simon added a comment - Thank you guys!
        Hide
        Rajesh Taneja added a comment -

        Thanks Jason,
        Blog entry can be deleted now and is not coming back after running cron.

        Show
        Rajesh Taneja added a comment - Thanks Jason, Blog entry can be deleted now and is not coming back after running cron.
        Hide
        Dan Poltawski added a comment -

        Jolly good show!

        Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.

        Tally-ho!

        Show
        Dan Poltawski added a comment - Jolly good show! Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale. Tally-ho!

          People

          • Votes:
            8 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: