Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Questions
    • Labels:
      None
    • Testing Instructions:
      Hide

      Create numerical questions with the option Units are input using set to both "a multiple choice selection" and "a drop-down menu".

      You will need to create the question with some units too.

      Verify that both sorts of question work as expected.

      Show
      Create numerical questions with the option Units are input using set to both "a multiple choice selection" and "a drop-down menu". You will need to create the question with some units too. Verify that both sorts of question work as expected.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      17922

      Description

      The 2,0 offers an additional help for the available number formats and a separate unit input element.

      1. As the new renderer code already use an additional left or right unit select element, we can easily maintain the separate unit text input.
      2. The help element could be offer as additional choices as just setting an option on the edit form is easier than writing all the available formats.
      3. The actual renderer use a select element to render multiple choice unit option.
        This cannot easily render units with exponents and complex structure.
        The 2,0 simple input text element allows some HTML formatting as <sub> and <sup>
        • We could offer either the select element or the multiple choice radio type as in 2,0 to display the unit choices.
      4. As the instruction field with its HTML editor has been removed, we can easily add HTML unit editing in the edit_numerical_form without having a more complex display than the 2,0.

        Activity

        Hide
        Tim Hunt added a comment -

        I think (once MDL-27418 is done, and we now have a plan for that) we have now dealt with all of this, except the change of radio buttons -> select menu, which breaks units with superscript and subscript. Hmm. I really don't want to use the HTML editor for units. That is overkill. OK. I will think about putting back the radio button option - and use that for questions upgraded from 2.0. I will probably keep the select menu option as a new option that teachers can choose. For questions with simple units, it is much neater.

        Regarding 2. I would rather not use a help icon. Instead, if what the student types is not recognised, we will display a validation error. I think that is a better way to handle this

        Show
        Tim Hunt added a comment - I think (once MDL-27418 is done, and we now have a plan for that) we have now dealt with all of this, except the change of radio buttons -> select menu, which breaks units with superscript and subscript. Hmm. I really don't want to use the HTML editor for units. That is overkill. OK. I will think about putting back the radio button option - and use that for questions upgraded from 2.0. I will probably keep the select menu option as a new option that teachers can choose. For questions with simple units, it is much neater. Regarding 2. I would rather not use a help icon. Instead, if what the student types is not recognised, we will display a validation error. I think that is a better way to handle this
        Hide
        Tim Hunt added a comment -

        I did what I proposed above. Questions upgraded from 2.0 will still use radio buttons for the unit, so <sup> and <sub> work; while there is a new option to use a drop-down menu.

        Show
        Tim Hunt added a comment - I did what I proposed above. Questions upgraded from 2.0 will still use radio buttons for the unit, so <sup> and <sub> work; while there is a new option to use a drop-down menu.
        Hide
        Pierre Pichet added a comment -

        I agree.

        Show
        Pierre Pichet added a comment - I agree.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Helen Foster added a comment -

        Thanks Pierre and Tim, test passed as described.

        Show
        Helen Foster added a comment - Thanks Pierre and Tim, test passed as described.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Upstream-ized! Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Upstream-ized! Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: