Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.1
    • Component/s: Accessibility
    • Labels:
    • Testing Instructions:
      Hide

      1. Find any page (e.g. form) including help icons.
      2. Using a tool that displays the alt text of the Help icon, verify that the alt text is 'Help with (Name of thing)'.

      Show
      1. Find any page (e.g. form) including help icons. 2. Using a tool that displays the alt text of the Help icon, verify that the alt text is 'Help with (Name of thing)'.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-27431-master
    • Rank:
      16988

      Description

      From our accessibility expert:

      Help icon alt text is e.g 'completion tick boxes' whereas the title attribute is 'Help with Completion tick boxes'. Screenreaders will not read title attribute. Recommendation: Alt text needs to match the title (so it includes the word 'Help').

        Activity

        Hide
        John Beedell added a comment -

        I have put a fix for this on https://github.com/Beedell/moodle/tree/wip-MDL-27431-master (commit 439fa3bad13a64fb1de2). Please let me know whether this is acceptable or needs improvement.

        Show
        John Beedell added a comment - I have put a fix for this on https://github.com/Beedell/moodle/tree/wip-MDL-27431-master (commit 439fa3bad13a64fb1de2). Please let me know whether this is acceptable or needs improvement.
        Hide
        Sam Marshall added a comment -

        Actual commit URL is currently:

        https://github.com/Beedell/moodle/commit/439fa3bad13a64fb1de2226c86232c52453d6d57

        John, the fix looks OK to me. Do you have access to submit for integration or should I...

        Show
        Sam Marshall added a comment - Actual commit URL is currently: https://github.com/Beedell/moodle/commit/439fa3bad13a64fb1de2226c86232c52453d6d57 John, the fix looks OK to me. Do you have access to submit for integration or should I...
        Hide
        Sam Marshall added a comment -

        also did you verify that with your fix, the test steps (above) pass?

        Show
        Sam Marshall added a comment - also did you verify that with your fix, the test steps (above) pass?
        Hide
        John Beedell added a comment -

        I did test as above, but I don't think I have access to submit for integration, sorry.

        Show
        John Beedell added a comment - I did test as above, but I don't think I have access to submit for integration, sorry.
        Hide
        Sam Marshall added a comment -

        OK, I will submit. Before I do, could you:

        1) Get current master from upstream and rebase your branch based on it
        2) Push it to github (you will need to push with --force)
        3) This will break the existing commit id, but the following URL will probably work:

        https://github.com/Beedell/moodle/compare/master...wip-MDL-27431_master

        (it is better to use URLs in this format as they are stable)

        Show
        Sam Marshall added a comment - OK, I will submit. Before I do, could you: 1) Get current master from upstream and rebase your branch based on it 2) Push it to github (you will need to push with --force) 3) This will break the existing commit id, but the following URL will probably work: https://github.com/Beedell/moodle/compare/master...wip-MDL-27431_master (it is better to use URLs in this format as they are stable)
        Hide
        John Beedell added a comment -
        Show
        John Beedell added a comment - Done, the new compare url is https://github.com/Beedell/moodle/compare/master...wip-MDL-27431-master .
        Hide
        Sam Marshall added a comment -

        Submitting this for integration now. It is not urgent so you may wish to wait until after 2.1 release (but, I think it should go 2.1.1, as it's an accessibility fix.)

        Show
        Sam Marshall added a comment - Submitting this for integration now. It is not urgent so you may wish to wait until after 2.1 release (but, I think it should go 2.1.1, as it's an accessibility fix.)
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Helen Foster added a comment -

        Thanks John and Sam, test passed as described.

        Show
        Helen Foster added a comment - Thanks John and Sam, test passed as described.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Upstream-ized! Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Upstream-ized! Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: