Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: DEV backlog
    • Fix Version/s: 2.1
    • Labels:
      None

      Gliffy Diagrams

        Attachments

          Activity

          Hide
          nebgor Aparup Banerjee added a comment -

          i've cherry-picked Eloy's fix @ MDL-27594 into my branch.

          but still seeing (using moodle.xml in mod data backup attachment):

          Exception: backup/converter/moodle1/simpletest/testlib.php / ► moodle1_converter_test / ► test_convert_run_convert
          Unexpected exception of type [xml_writer_exception] with message [Exception with missing language string

          {xml_writer_end_tag_no_match}

          from language file

          {error}

          with data

          {lastopen => [fields], tag => [field]}

          ] in [/home/aparup/mcode/m20/mysql/moodle/backup/util/xml/xml_writer.class.php line 196]
          line 223 of /backup/converter/moodle1/handlerlib.php: call to xml_writer->end_tag()
          line 130 of /mod/data/backup/moodle1/lib.php: call to moodle1_xml_handler->write_xml()
          line 268 of /backup/converter/moodle1/lib.php: call to moodle1_mod_data_handler->process_data_field()
          line 533 of /backup/converter/moodle1/lib.php: call to moodle1_converter->process_chunk()
          line 125 of /backup/util/xml/parser/processors/grouped_parser_processor.class.php: call to moodle1_parser_processor->dispatch_chunk()
          line 516 of /backup/converter/moodle1/lib.php: call to grouped_parser_processor->postprocess_chunk()
          line 148 of /backup/util/xml/parser/processors/simplified_parser_processor.class.php: call to moodle1_parser_processor->postprocess_chunk()
          line 92 of /backup/util/xml/parser/processors/progressive_parser_processor.class.php: call to simplified_parser_processor->process_chunk()
          line 169 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser_processor->receive_chunk()
          line 253 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser->publish()
          line ? of unknownfile: call to progressive_parser->end_tag()
          line 158 of /backup/util/xml/parser/progressive_parser.class.php: call to xml_parse()
          line 137 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser->parse()
          line 124 of /backup/converter/moodle1/lib.php: call to progressive_parser->process()
          line 85 of /backup/converter/convertlib.php: call to moodle1_converter->execute()
          line 139 of /backup/converter/moodle1/simpletest/testlib.php: call to base_converter->convert()
          line ... of ...

          Show
          nebgor Aparup Banerjee added a comment - i've cherry-picked Eloy's fix @ MDL-27594 into my branch. but still seeing (using moodle.xml in mod data backup attachment): Exception: backup/converter/moodle1/simpletest/testlib.php / ► moodle1_converter_test / ► test_convert_run_convert Unexpected exception of type [xml_writer_exception] with message [Exception with missing language string {xml_writer_end_tag_no_match} from language file {error} with data {lastopen => [fields], tag => [field]} ] in [/home/aparup/mcode/m20/mysql/moodle/backup/util/xml/xml_writer.class.php line 196] line 223 of /backup/converter/moodle1/handlerlib.php: call to xml_writer->end_tag() line 130 of /mod/data/backup/moodle1/lib.php: call to moodle1_xml_handler->write_xml() line 268 of /backup/converter/moodle1/lib.php: call to moodle1_mod_data_handler->process_data_field() line 533 of /backup/converter/moodle1/lib.php: call to moodle1_converter->process_chunk() line 125 of /backup/util/xml/parser/processors/grouped_parser_processor.class.php: call to moodle1_parser_processor->dispatch_chunk() line 516 of /backup/converter/moodle1/lib.php: call to grouped_parser_processor->postprocess_chunk() line 148 of /backup/util/xml/parser/processors/simplified_parser_processor.class.php: call to moodle1_parser_processor->postprocess_chunk() line 92 of /backup/util/xml/parser/processors/progressive_parser_processor.class.php: call to simplified_parser_processor->process_chunk() line 169 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser_processor->receive_chunk() line 253 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser->publish() line ? of unknownfile: call to progressive_parser->end_tag() line 158 of /backup/util/xml/parser/progressive_parser.class.php: call to xml_parse() line 137 of /backup/util/xml/parser/progressive_parser.class.php: call to progressive_parser->parse() line 124 of /backup/converter/moodle1/lib.php: call to progressive_parser->process() line 85 of /backup/converter/convertlib.php: call to moodle1_converter->execute() line 139 of /backup/converter/moodle1/simpletest/testlib.php: call to base_converter->convert() line ... of ...
          Hide
          nebgor Aparup Banerjee added a comment -

          https://github.com/nebgor/moodle/compare/mistress...MDL-27440 was borked in someway..
          heres the new branch which works for me , feel free to review:

          https://github.com/nebgor/moodle/compare/mistress...MDL-27440_chunkyfix

          Show
          nebgor Aparup Banerjee added a comment - https://github.com/nebgor/moodle/compare/mistress...MDL-27440 was borked in someway.. heres the new branch which works for me , feel free to review: https://github.com/nebgor/moodle/compare/mistress...MDL-27440_chunkyfix
          Hide
          mudrd8mz David Mudrák added a comment -

          if ($data['notification'] == null

          is not correct, you need either === or (which I prefer) is_null()

          Why is the commented part of process_data_field() still there?

          Please fix the invalid legacy call to get_moduleid() according the template.

          Please rebase your branch against the pre-integration backup-convert branch and require for the peer review again.

          Also, I am not really interested in the diff between your mistress branch and this branch. What I am interested in is the diff between my backup-convert branch and your branch. Please provide diff URLs accordingly.

          Thanks!

          Show
          mudrd8mz David Mudrák added a comment - if ($data['notification'] == null is not correct, you need either === or (which I prefer) is_null() Why is the commented part of process_data_field() still there? Please fix the invalid legacy call to get_moduleid() according the template. Please rebase your branch against the pre-integration backup-convert branch and require for the peer review again. Also, I am not really interested in the diff between your mistress branch and this branch. What I am interested in is the diff between my backup-convert branch and your branch. Please provide diff URLs accordingly. Thanks!
          Hide
          nebgor Aparup Banerjee added a comment - - edited

          David, thanks for reviewing,

          • is_null() is used now.
          • comment removed
          • i didn't get around to updating after template changes, just updated to the latest template.
          • rebased

          https://github.com/nebgor/moodle/compare/backup-convert...MDL-27440_chunkyfix

          see also : https://github.com/mudrd8mz/moodle/pull/1

          Show
          nebgor Aparup Banerjee added a comment - - edited David, thanks for reviewing, is_null() is used now. comment removed i didn't get around to updating after template changes, just updated to the latest template. rebased https://github.com/nebgor/moodle/compare/backup-convert...MDL-27440_chunkyfix see also : https://github.com/mudrd8mz/moodle/pull/1
          Hide
          mudrd8mz David Mudrák added a comment -

          Merged into backup-convert pre-integration branch. Thanks!

          Show
          mudrd8mz David Mudrák added a comment - Merged into backup-convert pre-integration branch. Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Jul/11