Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: DEV backlog
    • Fix Version/s: 2.1
    • Component/s: Feedback
    • Labels:
      None
    • Rank:
      1226

      Activity

      Hide
      Aparup Banerjee added a comment -

      Hi Rossi,

      The call to write_xml, perhaps it could be more like :
      $this->write_xml('item', $data, array('/item/id'));

      the phpdoc for the fourth argument to write_xml() mentions not to use it (its optional), its really there only for recursion purposes.

      The rest looks all good to me.

      cheers,
      Aparup

      Show
      Aparup Banerjee added a comment - Hi Rossi, The call to write_xml, perhaps it could be more like : $this->write_xml('item', $data, array('/item/id')); the phpdoc for the fourth argument to write_xml() mentions not to use it (its optional), its really there only for recursion purposes. The rest looks all good to me. cheers, Aparup
      Hide
      Rossiani Wijaya added a comment -

      Ah, I didn't update the argument for this patch.

      Will update the patch on Thursday.

      Thanks Apu.

      Show
      Rossiani Wijaya added a comment - Ah, I didn't update the argument for this patch. Will update the patch on Thursday. Thanks Apu.
      Hide
      Rossiani Wijaya added a comment -

      update patches and submit github pull request for David:
      https://github.com/mudrd8mz/moodle/pull/4

      Show
      Rossiani Wijaya added a comment - update patches and submit github pull request for David: https://github.com/mudrd8mz/moodle/pull/4
      Hide
      David Mudrak added a comment -

      Why is not the pageaftersub renamed using a recipe in get_paths()? Note that using a recipe is preferred as then the data are consistent with those being eventually passed to on_feedback_end() later.

      Show
      David Mudrak added a comment - Why is not the pageaftersub renamed using a recipe in get_paths()? Note that using a recipe is preferred as then the data are consistent with those being eventually passed to on_feedback_end() later.
      Hide
      Rossiani Wijaya added a comment -

      Thanks for commenting David.

      Fixed the patch as suggested.

      Resubmitted patch for github pull request:
      https://github.com/mudrd8mz/moodle/pull/7

      Show
      Rossiani Wijaya added a comment - Thanks for commenting David. Fixed the patch as suggested. Resubmitted patch for github pull request: https://github.com/mudrd8mz/moodle/pull/7
      Hide
      David Mudrak added a comment -

      Thanks Rossie, looking good now.

      Show
      David Mudrak added a comment - Thanks Rossie, looking good now.
      Hide
      David Mudrak added a comment -

      Merged into the pre-integration branch.

      Show
      David Mudrak added a comment - Merged into the pre-integration branch.

        People

        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: