Details
Sub-task
Minor
Activity
Ah, I didn't update the argument for this patch.
Will update the patch on Thursday.
Thanks Apu.
Show
Rossiani Wijaya
added a comment - Ah, I didn't update the argument for this patch.
Will update the patch on Thursday.
Thanks Apu.
update patches and submit github pull request for David:
https://github.com/mudrd8mz/moodle/pull/4
Show
Rossiani Wijaya
added a comment - update patches and submit github pull request for David:
https://github.com/mudrd8mz/moodle/pull/4
Why is not the pageaftersub renamed using a recipe in get_paths()? Note that using a recipe is preferred as then the data are consistent with those being eventually passed to on_feedback_end() later.
Show
David Mudrak
added a comment - Why is not the pageaftersub renamed using a recipe in get_paths()? Note that using a recipe is preferred as then the data are consistent with those being eventually passed to on_feedback_end() later.
Thanks for commenting David.
Fixed the patch as suggested.
Resubmitted patch for github pull request:
https://github.com/mudrd8mz/moodle/pull/7
Show
Rossiani Wijaya
added a comment - Thanks for commenting David.
Fixed the patch as suggested.
Resubmitted patch for github pull request:
https://github.com/mudrd8mz/moodle/pull/7
Thanks Rossie, looking good now.
Show
David Mudrak
added a comment - Thanks Rossie, looking good now.
Merged into the pre-integration branch.
Show
David Mudrak
added a comment - Merged into the pre-integration branch.
Hi Rossi,
The call to write_xml, perhaps it could be more like :
$this->write_xml('item', $data, array('/item/id'));
the phpdoc for the fourth argument to write_xml() mentions not to use it (its optional), its really there only for recursion purposes.
The rest looks all good to me.
cheers,
Aparup