Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: DEV backlog
    • Fix Version/s: 2.1
    • Component/s: Quiz
    • Labels:
      None
    • Rank:
      1232

      Issue Links

        Activity

        Hide
        Aparup Banerjee added a comment -

        i'm trying to create a proper 1.9 quiz backup test data set.

        Tim, i'm sure i won't be doing the best of job generating this data with all the possible options, could you provide a reasonable backup to test against ?

        Show
        Aparup Banerjee added a comment - i'm trying to create a proper 1.9 quiz backup test data set. Tim, i'm sure i won't be doing the best of job generating this data with all the possible options, could you provide a reasonable backup to test against ?
        Hide
        David Mudrak added a comment -

        Tim is on holiday. It's all up to you soldier! Go go! Please note the quiz itself should not be that hard. Just do not forget to annotate used questions in inforef.xml. I am working on the question bank conversion.

        Show
        David Mudrak added a comment - Tim is on holiday. It's all up to you soldier! Go go! Please note the quiz itself should not be that hard. Just do not forget to annotate used questions in inforef.xml. I am working on the question bank conversion.
        Hide
        Aparup Banerjee added a comment -

        David, i didn't create inforef that you mentioend in devchat yet.
        but can you have a review of this for now?

        Show
        Aparup Banerjee added a comment - David, i didn't create inforef that you mentioend in devchat yet. but can you have a review of this for now?
        Hide
        David Mudrak added a comment -

        In process_quiz_question_instance(), why not to use write_xml() instead of the foreach loop? Same applies to process_quiz_feedback(). The write_xml() is intended for complete structures including end tag. We use foreach loop only when we can't close the wrapping tag yet. The rest is looking good to me (from a formal point of view without studying the upgrade logic).

        Show
        David Mudrak added a comment - In process_quiz_question_instance(), why not to use write_xml() instead of the foreach loop? Same applies to process_quiz_feedback(). The write_xml() is intended for complete structures including end tag. We use foreach loop only when we can't close the wrapping tag yet. The rest is looking good to me (from a formal point of view without studying the upgrade logic).
        Hide
        Aparup Banerjee added a comment -

        thanks for the quick review David , yea i realised that too after en_tag() right after loop lol, was rushing to test it hehe...

        i'm assuming numeric precision data changes are taken care of while being inserted into the db , that should be ok.. unless these converters are used for other purposes.

        changing that stupid loop now..

        Show
        Aparup Banerjee added a comment - thanks for the quick review David , yea i realised that too after en_tag() right after loop lol, was rushing to test it hehe... i'm assuming numeric precision data changes are taken care of while being inserted into the db , that should be ok.. unless these converters are used for other purposes. changing that stupid loop now..
        Hide
        Aparup Banerjee added a comment -

        ok updated https://github.com/nebgor/moodle/compare/backup-convert...MDL-27447

        i've also received a big quiz zip from Ulrike Montgomery (thanks ) that i'll be testing with tomorrow. g'night!

        Show
        Aparup Banerjee added a comment - ok updated https://github.com/nebgor/moodle/compare/backup-convert...MDL-27447 i've also received a big quiz zip from Ulrike Montgomery (thanks ) that i'll be testing with tomorrow. g'night!
        Hide
        Aparup Banerjee added a comment -

        i've just rebased this branch onto david's current backup-convert branch

        Show
        Aparup Banerjee added a comment - i've just rebased this branch onto david's current backup-convert branch
        Hide
        Aparup Banerjee added a comment -

        David,
        this should be ready for your pre-integration branch.

        testing was fine with my small quiz backup. (attached)

        Show
        Aparup Banerjee added a comment - David, this should be ready for your pre-integration branch. testing was fine with my small quiz backup. (attached)
        Hide
        David Mudrak added a comment -

        Waiting for the pull request at github

        Show
        David Mudrak added a comment - Waiting for the pull request at github
        Show
        Aparup Banerjee added a comment - done @ https://github.com/mudrd8mz/moodle/pull/11
        Hide
        David Mudrak added a comment -

        Done. Combined with the MDL-27626, this seems to be able to convert all standard question types.

        Show
        David Mudrak added a comment - Done. Combined with the MDL-27626 , this seems to be able to convert all standard question types.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: