Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: DEV backlog
    • Fix Version/s: 2.1
    • Component/s: Survey
    • Labels:
      None

      Gliffy Diagrams

        Activity

        Hide
        Rossiani Wijaya added a comment -

        Hi Andrew,

        When you have a chance, could you take a look this.

        Thanks

        Show
        Rossiani Wijaya added a comment - Hi Andrew, When you have a chance, could you take a look this. Thanks
        Hide
        Andrew Davis added a comment -

        looks good

        Show
        Andrew Davis added a comment - looks good
        Hide
        Andrew Davis added a comment -

        Oh, one thing, the format of your commit message is slightly off. Personally i wouldn't worry about trying to fix this commit but for future reference here is the guide http://docs.moodle.org/en/Development:Commit_cheat_sheet#Provide_clear_commit_messages

        Show
        Andrew Davis added a comment - Oh, one thing, the format of your commit message is slightly off. Personally i wouldn't worry about trying to fix this commit but for future reference here is the guide http://docs.moodle.org/en/Development:Commit_cheat_sheet#Provide_clear_commit_messages
        Hide
        Rossiani Wijaya added a comment -

        Thank Andrew for reviewing and reference.

        I will make sure to follow the guide for commit message.

        Show
        Rossiani Wijaya added a comment - Thank Andrew for reviewing and reference. I will make sure to follow the guide for commit message.
        Hide
        Rossiani Wijaya added a comment -

        Assigning David as peer review.

        Show
        Rossiani Wijaya added a comment - Assigning David as peer review.
        Hide
        Andrew Davis added a comment -

        David is a bit snowed under right so I've had a look. Looks good to me.

        Show
        Andrew Davis added a comment - David is a bit snowed under right so I've had a look. Looks good to me.
        Hide
        Rossiani Wijaya added a comment -

        Submitted to github pull request for David:
        https://github.com/mudrd8mz/moodle/pull/2

        Show
        Rossiani Wijaya added a comment - Submitted to github pull request for David: https://github.com/mudrd8mz/moodle/pull/2
        Hide
        David Mudrak added a comment -

        Merged into the pre-integration branch. Thanks!

        Show
        David Mudrak added a comment - Merged into the pre-integration branch. Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: