Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22414 META: Restore 1.9 backups into Moodle 2.1 (phase 1)
  3. MDL-27475

Modify start/dispatch/end notifications to be called in correct order

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Backup
    • Testing Instructions:
      Hide
      • Run the unit tests (Admin -> Developer -> Unit tests) by specifying "backup/util/xml/parser".
      • TEST: All the tests pass ok
      • TEST: The number of tests is, at least 216

      (note this is one 2.1dev only integration)

      Show
      Run the unit tests (Admin -> Developer -> Unit tests) by specifying "backup/util/xml/parser". TEST: All the tests pass ok TEST: The number of tests is, at least 216 (note this is one 2.1dev only integration)
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      start_end_notifications
    • Pull Master Diff URL:

      Description

      It has been detected that the new start/end notifications were being dispatched in incorrect order some times.

      It was caused because we were using some parser internals to perform the notification. So the idea is to move the notifications to proper place, unrelated with parser and "ordered" for any reader (human or machine).

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27594 XML start/end parsing modifications correct order on empty paths

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27693 Yet another issue with the order of start/process/end handlers in the progressive parser

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Integrator:
              Sam Hemelryk
              Tester:
              Helen Foster
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Jul/11