Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27494

Wrong column name in choice 2.0 backup code

    Details

    • Testing Instructions:
      Hide

      Difficulty: requires backup/restore

      1. make a backup of a course in 2.0 with instances of the Choice module - one having "Show unanswered" set to Yes, the other one to "No"
      2. restore the course
      3. TEST: make sure that the setting is restored correctly

      Show
      Difficulty: requires backup/restore 1. make a backup of a course in 2.0 with instances of the Choice module - one having "Show unanswered" set to Yes, the other one to "No" 2. restore the course 3. TEST: make sure that the setting is restored correctly
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull Master Branch:

      Description

      The file mod/choice/backup/moodle2/backup_choice_stepslib.php declares that a field 'allowunanswered' should be written into choice.xml. But such column does not exist, the right name should be 'showunanswered'.

        Gliffy Diagrams

          Activity

          Hide
          mudrd8mz David Mudrak added a comment -

          Increasing the priority as the issue may lead to data loss.

          Show
          mudrd8mz David Mudrak added a comment - Increasing the priority as the issue may lead to data loss.
          Hide
          blepoxp Glenn Ansley added a comment -

          Confirmed bug. Working on solution.

          Show
          blepoxp Glenn Ansley added a comment - Confirmed bug. Working on solution.
          Hide
          blepoxp Glenn Ansley added a comment -

          Okay. I've tested the above suggested fix and it appears to have resolved the problem. Adding diff URL.

          Show
          blepoxp Glenn Ansley added a comment - Okay. I've tested the above suggested fix and it appears to have resolved the problem. Adding diff URL.
          Hide
          mudrd8mz David Mudrak added a comment -

          Yup, that's it. Please submit for integration

          Show
          mudrd8mz David Mudrak added a comment - Yup, that's it. Please submit for integration
          Hide
          blepoxp Glenn Ansley added a comment -

          Hi David,
          I may not have permission to do that. I can't seem to find the button / link here. It's also a real possibility that I'm just blind.

          Show
          blepoxp Glenn Ansley added a comment - Hi David, I may not have permission to do that. I can't seem to find the button / link here. It's also a real possibility that I'm just blind.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Submitted for integration, thanks!

          Note for integration: Cherry-pick for master

          Note to Glenn: It's useful to have also the master and MOODLE_XX_STABLE branches in you repo at github, that way you can provide the diff URL as something like:

          https://github.com/glennansley/moodle/compare/MOODLE_20_STABLE...MDL-27494

          that is more verbose than using the commit id (that is correct too, np, just one recommendation)

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Submitted for integration, thanks! Note for integration: Cherry-pick for master Note to Glenn: It's useful to have also the master and MOODLE_XX_STABLE branches in you repo at github, that way you can provide the diff URL as something like: https://github.com/glennansley/moodle/compare/MOODLE_20_STABLE...MDL-27494 that is more verbose than using the commit id (that is correct too, np, just one recommendation) Ciao
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          edited because the information given corresponds to master and not to 2.0.

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - edited because the information given corresponds to master and not to 2.0.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          This has been integrated, thanks!

          Note: I've amended the commit text, to follow recommendations (include the MDL issue + formatting).

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - This has been integrated, thanks! Note: I've amended the commit text, to follow recommendations (include the MDL issue + formatting).
          Hide
          blepoxp Glenn Ansley added a comment -

          Thanks for all the recommendations Eloy. I'll try to hit standards better on future patches to make integration easier.

          Show
          blepoxp Glenn Ansley added a comment - Thanks for all the recommendations Eloy. I'll try to hit standards better on future patches to make integration easier.
          Hide
          tsala Helen Foster added a comment -

          Tested on local 20 stable site and found choice module settings backed up and restored perfectly. Thanks for fixing Glenn!

          Show
          tsala Helen Foster added a comment - Tested on local 20 stable site and found choice module settings backed up and restored perfectly. Thanks for fixing Glenn!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          This has been sent to upstream, many thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - This has been sent to upstream, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Aug/11