Moodle
  1. Moodle
  2. MDL-27500

Upgrade TinyMCE to the latest version

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: HTML Editor (TinyMCE)
    • Labels:
      None
    • Rank:
      17162

      Description

      TinyMCE is currently at 3.4.2: http://tinymce.moxiecode.com/ https://github.com/tinymce/tinymce

      In Moodle 2.1 we currently have 3.3.9.2.

      Upgrade procedure (from lib/editor/tinymce/readme_moodle.txt) :

      1/ clone http://github.com/skodak/tinymce
      2/ clone http://github.com/skodak/tinymce_spellchecker_php
      3/ merge new changes in MOODLE_20_STABLE branches in these těo repos
      4/ tweak paths in build script in moodle_build.sh and execute
      5/ fix line endings
      6/ download all TinyMCE lang files (extra/tools/download_langs.sh)
      7/ update moodle lang string files (extra/tools/update_lang_files.php)

        Issue Links

          Activity

          Hide
          Aparup Banerjee added a comment -
          Show
          Aparup Banerjee added a comment - the repo in steps 1 & 2 can also be accessed at : https://github.com/moodle/custom-tinymce and https://github.com/moodle/custom-tinymce_spellchecker_php
          Hide
          Aparup Banerjee added a comment -

          https://github.com/moodle/custom-tinymce_spellchecker_php has just a few tags: i guess i'm going with the latest @ 2.0.5

          Show
          Aparup Banerjee added a comment - https://github.com/moodle/custom-tinymce_spellchecker_php has just a few tags: i guess i'm going with the latest @ 2.0.5
          Hide
          Aparup Banerjee added a comment -

          in step 7, there seems to be a lot of lang files (from step 6) but only lib/editor/tinymce/lang/en/editor_tinymce.php gets affected. do i need to do anything that uses the downloaded lang files as updates for the other languages?

          Show
          Aparup Banerjee added a comment - in step 7, there seems to be a lot of lang files (from step 6) but only lib/editor/tinymce/lang/en/editor_tinymce.php gets affected. do i need to do anything that uses the downloaded lang files as updates for the other languages?
          Hide
          Aparup Banerjee added a comment -

          ah! other lang files updated(generated) have a nice comment up top:
          // upload this file into the AMOS stage, rebase the stage, review the changes and commit

          Show
          Aparup Banerjee added a comment - ah! other lang files updated(generated) have a nice comment up top: // upload this file into the AMOS stage, rebase the stage, review the changes and commit
          Hide
          Aparup Banerjee added a comment -

          attaching updated language pack generated from steps 6-7. These need to be updated into AMOS.

          Show
          Aparup Banerjee added a comment - attaching updated language pack generated from steps 6-7. These need to be updated into AMOS.
          Hide
          Aparup Banerjee added a comment -

          note: do not close this issue until lang pack is updated into AMOS.

          Show
          Aparup Banerjee added a comment - note: do not close this issue until lang pack is updated into AMOS.
          Hide
          Dongsheng Cai added a comment -

          Looks fine to me

          Show
          Dongsheng Cai added a comment - Looks fine to me
          Hide
          David Mudrak added a comment -

          The new language packs published at AMOS portal so that language pack maintainers can import them into their Moodle lang packs. See http://lang.moodle.org/mod/forum/discuss.php?d=526 for the announcement. Thanks Apu.

          Show
          David Mudrak added a comment - The new language packs published at AMOS portal so that language pack maintainers can import them into their Moodle lang packs. See http://lang.moodle.org/mod/forum/discuss.php?d=526 for the announcement. Thanks Apu.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I'll be integrating this tomorrow. I've preferred to kill all the rest of stuff to have more time to "understand" this properly together with David's backup 19 one.

          In the mean time 2 comments/questions:

          1) Does the inclusion of this new version imply the deletion of the previous one.
          2) IMO just this (the tinymce editor) requires one QA complete test (all buttons, plugins...) per se. Feel free to discuss/create it.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - I'll be integrating this tomorrow. I've preferred to kill all the rest of stuff to have more time to "understand" this properly together with David's backup 19 one. In the mean time 2 comments/questions: 1) Does the inclusion of this new version imply the deletion of the previous one. 2) IMO just this (the tinymce editor) requires one QA complete test (all buttons, plugins...) per se. Feel free to discuss/create it. Ciao
          Hide
          Aparup Banerjee added a comment -

          Hi Eloy

          1) i supposed that the old version remained in case of regressions. (its also easy to test it with it around, just switching the versions used)

          2) yup, adding it to release notes so that it gets into QA

          Show
          Aparup Banerjee added a comment - Hi Eloy 1) i supposed that the old version remained in case of regressions. (its also easy to test it with it around, just switching the versions used) 2) yup, adding it to release notes so that it gets into QA
          Hide
          David Mudrak added a comment -

          Please note the upgrade does not seem to take lib/editor/tinymce/tiny_mce/3.3.9.2/plugins/ into account.

          Show
          David Mudrak added a comment - Please note the upgrade does not seem to take lib/editor/tinymce/tiny_mce/3.3.9.2/plugins/ into account.
          Hide
          Aparup Banerjee added a comment -

          David,
          i'm not sure i understand.

          Do you mean that the upgrade didn't upgrade the plugins?
          The upgrade script had generated the plugins too, so i was under the impression that the plugins were upgraded.

          is there a separate upgrade process to be done for each of the plugins?

          Show
          Aparup Banerjee added a comment - David, i'm not sure i understand. Do you mean that the upgrade didn't upgrade the plugins? The upgrade script had generated the plugins too, so i was under the impression that the plugins were upgraded. is there a separate upgrade process to be done for each of the plugins?
          Hide
          Helen Foster added a comment -

          Just wondering what should be checked when QA testing this issue? What are tinyMCE plugins? Apu, it would be really helpful if you could provide more detailed testing instructions.

          Show
          Helen Foster added a comment - Just wondering what should be checked when QA testing this issue? What are tinyMCE plugins? Apu, it would be really helpful if you could provide more detailed testing instructions.
          Hide
          David Mudrak added a comment -

          Apu: Ah sorry. I did not notice that our additional plugins are part of your branch. OK then.

          Helen: TinyMCE plugins are extensions that provide additional functionality. Typically our file picker, emoticons etc.

          Show
          David Mudrak added a comment - Apu: Ah sorry. I did not notice that our additional plugins are part of your branch. OK then. Helen: TinyMCE plugins are extensions that provide additional functionality. Typically our file picker, emoticons etc.
          Hide
          Aparup Banerjee added a comment -

          Helen: i'm writing up a list of tests for the tinyMCE plugins. will post here soon! (will probably get DS to review them too)

          David: :-p

          Show
          Aparup Banerjee added a comment - Helen: i'm writing up a list of tests for the tinyMCE plugins. will post here soon! (will probably get DS to review them too) David: :-p
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          This has been integrated, thanks!

          NOTE: I've deleted the old 3.3.9.2 version and upgraded version.php to get caches pruned.

          TODO: Some things that we must review related to this:

          1) Update the readme_moodle.txt to point to correct git repos (ping me once ready and I will cherry pick it).
          2) Anything to push to the github repositories (moodle / custom-tinymce and moodle / custom-tinymce_spellchecker_php)?
          3) Why are we using the 20_STABLE branch? There is something in the process that is not clear for me. Also there is one 34 branch there, not sure why.
          4) I've performed basic testing with Safari and got images/emoticons/repos working ok, but one QA tests for this would be perfect, nice you're working on it.
          5) Pass this as tested, tell me when the QA is available and I'll pass this.
          6) It seems that there are some "3.3.9.2" occurrences in our plugins, surely they should be also updated or so. Ask David.
          7) Done: MDL-27896 - It was detected that the course->summary (course/edit.php) was not setting the correct context into editor options, so the emoticons button was missing and not observing the filter settings for the course context). Afte chatting with David, we have agreed about to add some debugging/exceptions to file_prepare_editor() to detect situations like that in the future. At the same time the course/edit.php needs fixing. This point must go to new issue.

          Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - - edited This has been integrated, thanks! NOTE: I've deleted the old 3.3.9.2 version and upgraded version.php to get caches pruned. TODO: Some things that we must review related to this: 1) Update the readme_moodle.txt to point to correct git repos (ping me once ready and I will cherry pick it). 2) Anything to push to the github repositories (moodle / custom-tinymce and moodle / custom-tinymce_spellchecker_php)? 3) Why are we using the 20_STABLE branch? There is something in the process that is not clear for me. Also there is one 34 branch there, not sure why. 4) I've performed basic testing with Safari and got images/emoticons/repos working ok, but one QA tests for this would be perfect, nice you're working on it. 5) Pass this as tested, tell me when the QA is available and I'll pass this. 6) It seems that there are some "3.3.9.2" occurrences in our plugins, surely they should be also updated or so. Ask David. 7) Done: MDL-27896 - It was detected that the course->summary (course/edit.php) was not setting the correct context into editor options, so the emoticons button was missing and not observing the filter settings for the course context). Afte chatting with David, we have agreed about to add some debugging/exceptions to file_prepare_editor() to detect situations like that in the future. At the same time the course/edit.php needs fixing. This point must go to new issue. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Some suggested tests for QA:

          • test the emoticons plugin at course/section/activity (summaries / intros), playing with the emoticons filter enabled / disabled and inherited.
          Show
          Eloy Lafuente (stronk7) added a comment - Some suggested tests for QA: test the emoticons plugin at course/section/activity (summaries / intros), playing with the emoticons filter enabled / disabled and inherited.
          Show
          Aparup Banerjee added a comment - re 2) i've got https://github.com/nebgor/tinymce/compare/master...MDL-27500_MOODLE_21_STABLE --> https://github.com/nebgor/tinymce/commit/4ffda67589054af786c3228513bb841a468fffec and https://github.com/nebgor/tinymce_spellchecker_php/compare/master...MDL-27500_MOODLE_21_STABLE --> https://github.com/nebgor/tinymce_spellchecker_php/commit/73d7f24c9f5b285c9c8bd2c87672f7cd63780de8
          Hide
          Aparup Banerjee added a comment -

          re 6) yup just changing those version number - will create a fix along with the readme changes (1)..

          Show
          Aparup Banerjee added a comment - re 6) yup just changing those version number - will create a fix along with the readme changes (1)..
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Perfect, so we can reduce the pending points above to:

          a) commit to fix the numbers and the readme
          b) Done: push STABLE21 to moodle/xxx github's repos
          c) Say when the QA is ready

          gogogo! TIA!

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Perfect, so we can reduce the pending points above to: a) commit to fix the numbers and the readme b) Done: push STABLE21 to moodle/xxx github's repos c) Say when the QA is ready gogogo! TIA!
          Hide
          Aparup Banerjee added a comment -

          a) https://github.com/nebgor/moodle/compare/integration-master...MDL-27500_plugin_version_and_readme_updates
          b) thanks Eloy,
          c)

          Tiny MCE QA:

          • plugin : moodleemoticon
          • test TinyMCE popup window to insert a Moodle emoticon
          • test the emoticons plugin at course/section/activity (summaries / intros), playing with the emoticons filter enabled / disabled and inherited.
          • plugin : moodlemedia
          • test moodle media insertion / preview (playback) / test that the media is actually saved fine and retrieveable later.
          • plugin : moodlenolink
          • test moodle no link tags work

          (i shd improve that qa test but thats for now)

          Show
          Aparup Banerjee added a comment - a) https://github.com/nebgor/moodle/compare/integration-master...MDL-27500_plugin_version_and_readme_updates b) thanks Eloy, c) Tiny MCE QA: plugin : moodleemoticon test TinyMCE popup window to insert a Moodle emoticon test the emoticons plugin at course/section/activity (summaries / intros), playing with the emoticons filter enabled / disabled and inherited. plugin : moodlemedia test moodle media insertion / preview (playback) / test that the media is actually saved fine and retrieveable later. plugin : moodlenolink test moodle no link tags work (i shd improve that qa test but thats for now)
          Hide
          Helen Foster added a comment -

          Thanks Apu, I'll use your text and create a QA test for this today!

          Show
          Helen Foster added a comment - Thanks Apu, I'll use your text and create a QA test for this today!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          All points closed, passing this and igniting very first on-demand master-only upstream process.

          Thanks everybody!

          Show
          Eloy Lafuente (stronk7) added a comment - All points closed, passing this and igniting very first on-demand master-only upstream process. Thanks everybody!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Done, this is now in all (master) git and cvs repos, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Done, this is now in all (master) git and cvs repos, many thanks!
          Hide
          Helen Foster added a comment -

          MDLQA-1154 and MDLQA-1156 created. Apu, please could you confirm whether the no link tags prevent any / all of the autolinking filters from working and perhaps explain more of what exactly needs testing.

          Show
          Helen Foster added a comment - MDLQA-1154 and MDLQA-1156 created. Apu, please could you confirm whether the no link tags prevent any / all of the autolinking filters from working and perhaps explain more of what exactly needs testing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: