Moodle
  1. Moodle
  2. MDL-27508

Group filtering "drop-box" menu missing from workshop

    Details

    • Testing Instructions:
      Hide

      Testing difficulty: Easy, but time consuming

      1. Create a course with several groups and at least one grouping containing just some groups
      2. Enable "Available for group members only" experimental feature
      3. Create a workshop and let it be available for some grouping only
      4. TEST: Make sure that only users from the selected grouping are listed at workshop participants listings (eg at the Assessment phase page, at the Manual allocation page etc.) [Previously, workshop displayed all users in the course]
      5. Prepare another workshop with normal Visible groups mode
      6. TEST: Make sure that everywhere where workshop shows a list of users (Grades report, Manual allocation page etc.) the groups selector is available and working and also the pagination widgets are available and working [Previously, group selectors did not work]

      Show
      Testing difficulty: Easy, but time consuming 1. Create a course with several groups and at least one grouping containing just some groups 2. Enable "Available for group members only" experimental feature 3. Create a workshop and let it be available for some grouping only 4. TEST: Make sure that only users from the selected grouping are listed at workshop participants listings (eg at the Assessment phase page, at the Manual allocation page etc.) [Previously, workshop displayed all users in the course] 5. Prepare another workshop with normal Visible groups mode 6. TEST: Make sure that everywhere where workshop shows a list of users (Grades report, Manual allocation page etc.) the groups selector is available and working and also the pagination widgets are available and working [Previously, group selectors did not work]
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27508-workshop-groups
    • Rank:
      17171

      Description

      The Separate Groups "drop-down" menu is missing form the Workshop activity.

      This bug appeared once in 1.8 (see MDL 8564), but was fixed. Now it seems to have reappeared in 2.0.

      This feature is a must-have, because without it browsing students' assessments is very cumbersome, specially with courses with lots of students enrolled.

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          Thanks for reporting this. Agree, that is known missing feature and it must be introduced everyhere where there is a list of users - mainly the grades report and the manual allocator.

          Show
          David Mudrak added a comment - Thanks for reporting this. Agree, that is known missing feature and it must be introduced everyhere where there is a list of users - mainly the grades report and the manual allocator.
          Hide
          David Mudrak added a comment - - edited

          See a use case in MDL-28159, too.

          Show
          David Mudrak added a comment - - edited See a use case in MDL-28159 , too.
          Hide
          Andrea Bicciolo added a comment -

          Hi David, as more people is using workshop module, this feature is starting to be more asked. It would be great if you could take a look into.

          Show
          Andrea Bicciolo added a comment - Hi David, as more people is using workshop module, this feature is starting to be more asked. It would be great if you could take a look into.
          Hide
          David Mudrak added a comment -

          Submitting for integration. The basic idea of the whole patchset was:

          • prepare/fix some helper methods in locallib.php to support group selection and pagination of results effectively at DB level
          • add standard group selectors to all places where list of workshop participants is displayed
          • fix pagination at those places, too
          Show
          David Mudrak added a comment - Submitting for integration. The basic idea of the whole patchset was: prepare/fix some helper methods in locallib.php to support group selection and pagination of results effectively at DB level add standard group selectors to all places where list of workshop participants is displayed fix pagination at those places, too
          Hide
          David Mudrak added a comment -

          For those who will test this: I prepared a script that simply creates fake submissions for all potential authors in the given workshop.

          Put the script fakesubmissions.php into /mod/workshop and execute it via CLI, providing the cmid argument (which is the one passed at ?id to view.php via the web).

          Show
          David Mudrak added a comment - For those who will test this: I prepared a script that simply creates fake submissions for all potential authors in the given workshop. Put the script fakesubmissions.php into /mod/workshop and execute it via CLI, providing the cmid argument (which is the one passed at ?id to view.php via the web).
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Thanks David, i've integrated that now.

          Show
          Dan Poltawski added a comment - Thanks David, i've integrated that now.
          Hide
          Adrian Greeve added a comment -

          Tested with groupings and visible groups. The group selector and pagination work with no problems.
          Thanks.

          Show
          Adrian Greeve added a comment - Tested with groupings and visible groups. The group selector and pagination work with no problems. Thanks.
          Hide
          Eloy Lafuente (stronk7) added a comment -
          UPDATE tracker_issues
             SET status = 'Closed',
                comment = 'Thanks!'
          WHEN participants = 'Did a gorgeous work'
          

          This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

          Show
          Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).
          Hide
          Mary Cooch added a comment -

          just added mention of this in Workshop docs

          Show
          Mary Cooch added a comment - just added mention of this in Workshop docs

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: