Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27520

Add file support in the gradebook feedbacks

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide
      Prerequisite.
      1. A course with a user enrolled as a student.
      2. A course with a user enrolled as a teacher.
      3. An assignment with default settings.
      4. A computer that has a camera and a microphone.
      5. An audio file on your computer.
      6. A video file on your computer.
      7. A server set-up to allow you to upload enough data to upload the audio file, video file and make some recordings. This may require you updating your settings in php.ini, eg.

        ; Maximum allowed size for uploaded files.
        upload_max_filesize = 40M
         
        ; Must be greater than or equal to upload_max_filesize
        post_max_size = 40M
        

        Once changed you will need to restart your web server.

      1. Use Firefox.
      Test 1.
      1. Log in as a teacher.
      2. Click on the assignment.
      3. Click the 'Grade' button.
      4. Add a video recording to the feedback.
      5. Add an audio recording to the feedback.
      6. Add an image.
      7. Upload the audio file.
      8. Upload the video file.
      9. Click on 'Save changes'.
      10. Click on the name of the assignment at the top.
      11. Click on the 'Grade' button.
      12. Confirm the feedback loads with the data you had entered previously.
      Test 2

      Requires Test 1 to be done

      1. Log in as the student.
      2. Visit the course.
      3. Click on the assignment.
      4. Scroll down to the 'Feedback' area.
      5. Confirm you can see the media that was attached.
      6. Visit the course.
      7. Click on 'Grades'.
      8. Confirm you can see the media that was attached in the 'User report'.
      Test 3
      1. Create another assignment in the course with the setting 'Comment inline' set to 'Yes' AND 'Online text' submission checked.
      2. Log in as the student.
      3. Make a submission with some media files in the 'Online text' submission area and some text.
      4. Log in as the teacher.
      5. Click on the assignment.
      6. Click the 'Grade' button.
      7. Confirm the media is copied into the feedback area.
      8. Edit the feedback by changing the media and text.
      9. Log in as the student.
      10. View the assignment
      11. Confirm you see the media and the altered data in your feedback.
      Test 4
      1. Create a new course.
      2. Enrol the student from the course in Test 3.
      3. Backup the assignment from Test 3 with default settings.
      4. Restore it into the new course you created.
      5. Click on the assignment.
      6. Click on 'Grade'.
      7. Confirm the media displays as expected (the same as the assignment in Test 3).
      Test 5
      1. Backup the course from Test 3.
      2. Restore as a new course.
      3. Visit the gradebook.
      4. Go to the user report.
      5. View the report for the user you graded.
      6. Confirm the files are shown in the feedback area.
      Test 6
      1. Backup the course from Test 3 and choose to backup 'Grade history'.
      2. Restore as a new course.
      3. Visit the gradebook.
      4. Go to the history report.
      5. View the report for the user you graded.
      6. Confirm the files are shown
      Test 7
      1. Go to the course you made in test 3.
      2. Edit the feedback (add a new image, make a new comment, delete an image etc) and save. Do this multiple times.
      3. Visit the gradebook.
      4. Go to the grade history report.
      5. Confirm the history is correct and shows the changes and the media/files.

       h5. Test 8

      Continue from Test 7

      1. View the other reports in the gradebook and confirm they work as expected.

      Note - the single view report will show '@@PLUGINFILE@@', this will be dealt with in MDL-63489.

      Show
      Prerequisite. A course with a user enrolled as a student. A course with a user enrolled as a teacher. An assignment with default settings. A computer that has a camera and a microphone. An audio file on your computer. A video file on your computer. A server set-up to allow you to upload enough data to upload the audio file, video file and make some recordings. This may require you updating your settings in php.ini, eg. ; Maximum allowed size for uploaded files. upload_max_filesize = 40M   ; Must be greater than or equal to upload_max_filesize post_max_size = 40M Once changed you will need to restart your web server. Use Firefox. Test 1. Log in as a teacher. Click on the assignment. Click the 'Grade' button. Add a video recording to the feedback. Add an audio recording to the feedback. Add an image. Upload the audio file. Upload the video file. Click on 'Save changes'. Click on the name of the assignment at the top. Click on the 'Grade' button. Confirm the feedback loads with the data you had entered previously. Test 2 Requires Test 1 to be done Log in as the student. Visit the course. Click on the assignment. Scroll down to the 'Feedback' area. Confirm you can see the media that was attached. Visit the course. Click on 'Grades'. Confirm you can see the media that was attached in the 'User report'. Test 3 Create another assignment in the course with the setting 'Comment inline' set to 'Yes' AND 'Online text' submission checked. Log in as the student. Make a submission with some media files in the 'Online text' submission area and some text. Log in as the teacher. Click on the assignment. Click the 'Grade' button. Confirm the media is copied into the feedback area. Edit the feedback by changing the media and text. Log in as the student. View the assignment Confirm you see the media and the altered data in your feedback. Test 4 Create a new course. Enrol the student from the course in Test 3. Backup the assignment from Test 3 with default settings. Restore it into the new course you created. Click on the assignment. Click on 'Grade'. Confirm the media displays as expected (the same as the assignment in Test 3). Test 5 Backup the course from Test 3. Restore as a new course. Visit the gradebook. Go to the user report. View the report for the user you graded. Confirm the files are shown in the feedback area. Test 6 Backup the course from Test 3 and choose to backup 'Grade history'. Restore as a new course. Visit the gradebook. Go to the history report. View the report for the user you graded. Confirm the files are shown Test 7 Go to the course you made in test 3. Edit the feedback (add a new image, make a new comment, delete an image etc) and save. Do this multiple times. Visit the gradebook. Go to the grade history report. Confirm the history is correct and shows the changes and the media/files.  h5. Test 8 Continue from Test 7 View the other reports in the gradebook and confirm they work as expected. Note - the single view report will show '@@PLUGINFILE@@', this will be dealt with in MDL-63489 .
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_28_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27520_master

      Description

      (Apologies if this has been tracked already - I still find it hard to search on here!) When giving feedback to a submitted assignment it is not possible either to make a hyperlink and upload a file or to insert an image or embedded media because the file picker option does not appear in the TinyMCE editor as it does elsewhere. This means for example a teacher could not upload audio or video feedback into the editor as they could in 1.9

        Attachments

        1. 1.PNG
          1.PNG
          235 kB
        2. 2.PNG
          2.PNG
          129 kB
        3. 3.PNG
          3.PNG
          175 kB
        4. Outcome-grading_I-set-the-following-fields-to-these-values-_65.png
          Outcome-grading_I-set-the-following-fields-to-these-values-_65.png
          93 kB

          Issue Links

            Activity

              People

              • Votes:
                87 Vote for this issue
                Watchers:
                63 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h