Moodle

Documentation of superseded DB functions

Details

Description

In deprecatedlib.php there are numerous functions which have been deprecated in favour of the equivalents in the $DB object for Moodle 2.0. It would be useful if this was reflected in the PHPDoc comments, so that IDE users upgrading 1.9 plugins could easily see the documentation for the new functions.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Aherne added a comment -

This is my first pull request, so it may not be done correctly - any feedback welcome!

Show
Michael Aherne added a comment - This is my first pull request, so it may not be done correctly - any feedback welcome!
Hide
Permalink
Tim Hunt added a comment -

Looks like a good, simple and worthwhile change to me. Please can this be integrated on 2.1 and master branches.

Show
Tim Hunt added a comment - Looks like a good, simple and worthwhile change to me. Please can this be integrated on 2.1 and master branches.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks for the great improvement Michael, this has been integrated now.

Please note I didn't merge your changes in, I noticed before integration that the commit message didn't contain the bug number (a requirement we have).
As such I cherry-picked your improvements into each branch editing the commit as I did to insert the MDL issue number.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks for the great improvement Michael, this has been integrated now. Please note I didn't merge your changes in, I noticed before integration that the commit message didn't contain the bug number (a requirement we have). As such I cherry-picked your improvements into each branch editing the commit as I did to insert the MDL issue number. Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Passing testing as no testing is required

Show
Sam Hemelryk added a comment - Passing testing as no testing is required
Hide
Permalink
Petr Škoda added a comment -

Thanks everybody, this is now part of the weekly build.

Show
Petr Škoda added a comment - Thanks everybody, this is now part of the weekly build.

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: