Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27538

Documentation of superseded DB functions

    Details

      Description

      In deprecatedlib.php there are numerous functions which have been deprecated in favour of the equivalents in the $DB object for Moodle 2.0. It would be useful if this was reflected in the PHPDoc comments, so that IDE users upgrading 1.9 plugins could easily see the documentation for the new functions.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            maherne Michael Aherne added a comment -

            This is my first pull request, so it may not be done correctly - any feedback welcome!

            Show
            maherne Michael Aherne added a comment - This is my first pull request, so it may not be done correctly - any feedback welcome!
            Hide
            timhunt Tim Hunt added a comment -

            Looks like a good, simple and worthwhile change to me. Please can this be integrated on 2.1 and master branches.

            Show
            timhunt Tim Hunt added a comment - Looks like a good, simple and worthwhile change to me. Please can this be integrated on 2.1 and master branches.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks for the great improvement Michael, this has been integrated now.

            Please note I didn't merge your changes in, I noticed before integration that the commit message didn't contain the bug number (a requirement we have).
            As such I cherry-picked your improvements into each branch editing the commit as I did to insert the MDL issue number.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks for the great improvement Michael, this has been integrated now. Please note I didn't merge your changes in, I noticed before integration that the commit message didn't contain the bug number (a requirement we have). As such I cherry-picked your improvements into each branch editing the commit as I did to insert the MDL issue number. Cheers Sam
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Passing testing as no testing is required

            Show
            samhemelryk Sam Hemelryk added a comment - Passing testing as no testing is required
            Hide
            skodak Petr Skoda added a comment -

            Thanks everybody, this is now part of the weekly build.

            Show
            skodak Petr Skoda added a comment - Thanks everybody, this is now part of the weekly build.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11