Moodle
  1. Moodle
  2. MDL-27545

SCORM bug - mdl_log.action cannot insert long action field

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.12
    • Fix Version/s: 1.9.13
    • Component/s: SCORM
    • Labels:
    • Environment:
      Debian lenny
    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide

      I don't have a SCORM package that reproduces this, but it should be sufficient to run through a standard SCORM package with developer debugging turned on on a Postgres db and make sure that no sql errors occur.

      This may need to be tested/verified by a developer.

      Show
      I don't have a SCORM package that reproduces this, but it should be sufficient to run through a standard SCORM package with developer debugging turned on on a Postgres db and make sure that no sql errors occur. This may need to be tested/verified by a developer.
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      We have been seeing the following issues on our moodle 1.9.12 instance. The problem is that the "action" field of the mdl_log table is limited to 40 chars. This means that the below SQL is failing.

      Insert into log table failed at Thursday 12th of May 2011 12:00:41 PM.
      It is possible that your disk is full.

      The failed SQL is:

      INSERT INTO mdl_log (time, userid, course, ip, module, cmid, action, url, info)
      VALUES ('1305165641', '5', '1', '165.228.100.81', 'scorm', '11', 'trk: Clinical Management of the HPA Axis at: 1', 'view.php?id=11', 'cmi.core.score.raw => 0')

      We use postgres for our Moodle instances, this probably doesn't fire a bug with MySQL (which will sometimes just concatenate data to fit smaller data fields)

        Gliffy Diagrams

          Activity

          Hide
          Dan Marsden added a comment -

          Thanks Andrew - I think we're probably abusing the log table a bit there with debugging content instead of logging stuff - we probably need to cut the content of those logging messages back quite a bit.

          Show
          Dan Marsden added a comment - Thanks Andrew - I think we're probably abusing the log table a bit there with debugging content instead of logging stuff - we probably need to cut the content of those logging messages back quite a bit.
          Hide
          Dan Marsden added a comment -

          this patch is already in 2.0Stable as part of MDL-26880 it is only required in the 1.9Stable branch.

          Show
          Dan Marsden added a comment - this patch is already in 2.0Stable as part of MDL-26880 it is only required in the 1.9Stable branch.
          Hide
          Sam Hemelryk added a comment -

          Thanks Dan this has been integrated now.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Dan this has been integrated now. Cheers Sam
          Hide
          Rajesh Taneja added a comment -

          Great Work
          No errors...

          Show
          Rajesh Taneja added a comment - Great Work No errors...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And now this is part of the best Moodle weeklies ever, thanks!

          Closing.

          Show
          Eloy Lafuente (stronk7) added a comment - And now this is part of the best Moodle weeklies ever, thanks! Closing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: